chore(SREP-4482, SREP-4486, SREP-4800: Boilerplate Update for Agentic SDLC Rollout)#430
chore(SREP-4482, SREP-4486, SREP-4800: Boilerplate Update for Agentic SDLC Rollout)#430devppratik wants to merge 1 commit into
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@devppratik: This pull request references SREP-4482 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. This pull request references SREP-4486 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. This pull request references SREP-4800 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (8)
📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: devppratik The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@devppratik: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #430 +/- ##
=======================================
Coverage 72.44% 72.44%
=======================================
Files 11 11
Lines 704 704
=======================================
Hits 510 510
Misses 173 173
Partials 21 21 🚀 New features to boost your workflow:
|
| project: | ||
| default: | ||
| target: 35% | ||
| threshold: 1% | ||
| patch: | ||
| default: | ||
| target: 50% | ||
| threshold: 1% |
There was a problem hiding this comment.
What effect will this have on other PRs for this repo? Will it prevent them from passing until there is sufficient coverage or is it only for new code?
There was a problem hiding this comment.
Are these rules also enforced server-side during CI or just as part of local pre-commit hooks?
| # Auto-fix hooks (trailing-whitespace, end-of-file-fixer) will correct | ||
| # pre-existing violations on the first run. Stage and commit those fixes | ||
| # separately before day-to-day use. | ||
| # |
There was a problem hiding this comment.
| # | |
| # Fix commits can be excluded from git blame | |
| # https://git-scm.com/docs/git-blame#Documentation/git-blame.txt---ignore-revs-filefile | |
| # |
It would be a good idea to add these instructions to the Boilerplate file as well.
| # ============================================================================= | ||
| # | ||
| # INSTALL | ||
| # pip install pre-commit |
There was a problem hiding this comment.
| # pip install pre-commit | |
| # pip install 'pre-commit==4.6.0' |
Golden Rule 15 requires version pinning of dependencies and this needs to apply here as well. The change should be made in Boilerplate and pulled into the projects that consume it.
Also see this comment for more general suggestions regarding Python dependencies.
|
Why was a new PR opened for this? #426 should have been updated with the requested changes to preserve the discussion log. |
|
Python dependency management is typically done through virtual environments to ensure consistency. Although # Create pyproject.toml
$ uv init --bare
# add dependency and generate uv.lock file
$ uv add --dev pre-commit==4.6.0If $ uv syncFrom here $ source .venv/bin/activate
$ pre-commit install |
Regenerated boilerplate-managed files from image-v8.3.6: - Updated golang-osd-operator and golang-osd-e2e conventions - Added pre-commit hooks configuration - Updated build Dockerfiles with latest UBI base images - Updated OWNERS_ALIASES and codecov configuration - Updated linting and testing configurations This follows the same pattern as PR openshift#430 to bring in the latest boilerplate updates for CVE-2026-25679.
4 participants
What type of PR is this?
boilerplate
What this PR does / why we need it?
This PR moves the changes introduced in boilerplate for Agentic SDLC Rollout into MVP for ocm-agent-operator.
Related BP MRs
Which Jira/Github issue(s) this PR fixes?
Part of Rollout for Agentic SDLC -