[skmo] Follow-up refactoring: replace remaining shell tasks with k8s.core#3826
Conversation
vakwetu
force-pushed
the
skmo-followup-refactor
branch
from
6387588 to
545500b
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/aacfe7e6fbcd456ba53e88590b750d46 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 12m 53s |
vakwetu
force-pushed
the
skmo-followup-refactor
branch
from
545500b to
9c9fbda
Compare
|
/lgtm |
vakwetu
force-pushed
the
skmo-followup-refactor
branch
from
9c9fbda to
abf4a2d
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4a3cc92f29754dfe89181effa3a20f1e ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 14m 19s |
|
recheck |
evallesp
left a comment
evallesp
left a comment
There was a problem hiding this comment.
LGTM. There's a minor thing that I'm unsure how important is.
michburk
left a comment
michburk
left a comment
There was a problem hiding this comment.
Thanks for the follow-up changes! One small readability nit to consider, lgtm otherwise.
danpawlik
left a comment
danpawlik
left a comment
There was a problem hiding this comment.
looks fine.
if you want to fix nit(s), ping me :)
Address non-blocking review suggestions from evallesp and fultonj on ci-framework PR openstack-k8s-operators#3766. - Replace the 'Ensure leaf osp-secret exists' and 'Read leaf admin password' shell tasks with a single set_fact that parses the osp-secrets.env file directly using regex_findall. Pre-creating the secret in the leaf namespace is unnecessary because kustomize already creates it there during stage 6; the hook only ever needed the password value itself. - Replace the 'Create TransportURL CR' and 'Wait for TransportURL' shell tasks with kubernetes.core.k8s (idempotent apply) and kubernetes.core.k8s_info with retries/until (condition polling). Signed-off-by: Ade Lee <alee@redhat.com> Co-Authored-By: Claude <noreply@anthropic.com>
…trolplane_config Address non-blocking review suggestions from evallesp and michburk on ci-framework PR openstack-k8s-operators#3766. Refactor _federation_ca_bundle_secret_name to use chained | default() filters instead of nesting them. This removes the redundant trailing | default('custom-ca-certs', true) and flattens the remaining nested default into a more readable two-step chain: | default(cifmw_custom_ca_certs_secret_name, true) | default('custom-ca-certs', true) Signed-off-by: Ade Lee <alee@redhat.com> Co-Authored-By: Claude <noreply@anthropic.com>
vakwetu
force-pushed
the
skmo-followup-refactor
branch
from
abf4a2d to
62cd06b
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7ab0d26d2b7548c8981f9305572a31c2 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 49m 59s |
|
@evallesp @danpawlik @michburk - hi all, nits fixed. please merge! |
|
recheck |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michburk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit d4ae12d
into
openstack-k8s-operators:main
5 participants
Address non-blocking review suggestions from evallesp and fultonj on ci-framework PR #3766.
In hooks/playbooks/skmo/prepare-leaf.yaml:
In roles/federation/tasks/hook_controlplane_config.yml: