Skip to content

Add devscript_sno role#3839

Draft
danpawlik wants to merge 3 commits intoopenstack-k8s-operators:mainfrom
danpawlik:add-devscript-sno
Draft

Add devscript_sno role#3839
danpawlik wants to merge 3 commits intoopenstack-k8s-operators:mainfrom
danpawlik:add-devscript-sno

Conversation

@danpawlik
Copy link
Copy Markdown
Contributor

@danpawlik danpawlik commented Apr 8, 2026

Dedicated role that spawns SNO node.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 8, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 8, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign valkyrie00 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@danpawlik danpawlik changed the title Add devscript sno Add devscript_sno role Apr 8, 2026
@danpawlik danpawlik force-pushed the add-devscript-sno branch from 066f16b to 71c6280 Compare April 8, 2026 15:06
danpawlik added 2 commits April 8, 2026 17:09
@danpawlik
[devscripts_sno] Adding role for simply deploying SNO node
334174b 
TBD

Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
@danpawlik
[devscripts] Preserve host-passthrough CPU in metal3 devscripts
55f868f 
The metal3 generates a file in work dir:

    # metal3-dev-env/vm-setup/roles/libvirt/tasks/vm_setup_tasks.yml
    (...)
    - name: Detect virtualization if libvirt_domain_type is not provided
      command: systemd-detect-virt
      ignore_errors: true
      become: true
      register: virt_result

    - name: Default to qemu if inside a VM
      set_fact:
        libvirt_domain_type: qemu
      when: virt_result is succeeded

    - name: Default to kvm if a VM is not detected
      set_fact:
        libvirt_domain_type: kvm
      when: virt_result is failed
    when: libvirt_domain_type is undefined

which generates later in an SNO VM xml:

    <cpu mode='custom' match='exact' check='full'>
      <model fallback='forbid'>EPYC</model>
      <vendor>AMD</vendor>
      <feature policy='require' name='monitor'/>
      <feature policy='require' name='x2apic'/>
      <feature policy='require' name='hypervisor'/>
      <feature policy='require' name='acpi'/>
      <feature policy='require' name='ss'/>
      <feature policy='require' name='erms'/>
      <feature policy='require' name='mpx'/>
      <feature policy='require' name='clwb'/>
      <feature policy='require' name='umip'/>
      <feature policy='require' name='pku'/>
      <feature policy='require' name='vaes'/>
      <feature policy='require' name='la57'/>
      <feature policy='require' name='rdpid'/>
      <feature policy='require' name='pks'/>
      <feature policy='require' name='fsrm'/>
      <feature policy='require' name='cmpccxadd'/>
      <feature policy='require' name='fzrm'/>
      <feature policy='require' name='fsrs'/>
      <feature policy='require' name='fsrc'/>
      <feature policy='require' name='3dnowext'/>
      <feature policy='require' name='3dnow'/>
      <feature policy='require' name='xsaveerptr'/>
      <feature policy='require' name='wbnoinvd'/>
      <feature policy='require' name='npt'/>
      <feature policy='require' name='vgif'/>
      <feature policy='require' name='svme-addr-chk'/>
      <feature policy='require' name='no-nested-data-bp'/>
      <feature policy='require' name='null-sel-clr-base'/>
      <feature policy='disable' name='vme'/>
      <feature policy='disable' name='xsavec'/>
      <feature policy='disable' name='misalignsse'/>
      <feature policy='disable' name='osvw'/>
      <feature policy='disable' name='topoext'/>
      <feature policy='disable' name='fxsr_opt'/>
      <feature policy='disable' name='nrip-save'/>
    </cpu>

instead of host-passthrough. Bypass that behavior and always use
host-passthrough.

Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
@danpawlik danpawlik force-pushed the add-devscript-sno branch from 71c6280 to 55f868f Compare April 8, 2026 15:09
@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul bot commented Apr 8, 2026

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2eb20f8b4aa14d77be159a71b07de975

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 22m 04s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 26m 58s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 33m 55s
✔️ cifmw-crc-podified-edpm-baremetal-minor-update SUCCESS in 2h 08m 45s
❌ cifmw-pod-zuul-files FAILURE in 4m 54s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 42s
❌ cifmw-pod-pre-commit FAILURE in 9m 08s
❌ cifmw-molecule-devscripts FAILURE in 11m 01s

@danpawlik
[multiple] Various changes related to devscripts_sno role
0e341f7 
TBD

Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
@danpawlik danpawlik force-pushed the add-devscript-sno branch from eb47368 to 0e341f7 Compare April 9, 2026 14:59
@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul bot commented Apr 9, 2026

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/989527450c7940fcb3b19126eede8214

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 17m 37s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 24m 12s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 33m 26s
✔️ cifmw-crc-podified-edpm-baremetal-minor-update SUCCESS in 2h 02m 41s
❌ cifmw-pod-zuul-files FAILURE in 4m 41s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 27s
❌ cifmw-pod-pre-commit FAILURE in 8m 27s
❌ cifmw-molecule-devscripts FAILURE in 10m 30s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge/work-in-progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@danpawlik