[OSPRH-28763] Add binary, zone, status labels for volume service health metrics#31
Draft
vyzigold wants to merge 1 commit into
Draft
[OSPRH-28763] Add binary, zone, status labels for volume service health metrics#31vyzigold wants to merge 1 commit into
vyzigold wants to merge 1 commit into
Conversation
Add support for parsing and exposing binary, zone, and status labels from ceilometer volume.service.health metrics in the sg-core ceilometer handler plugin. This ensures the Prometheus metrics exported by sg-core match the labels produced by ceilometer's built-in prometheus exporter. - Add Binary, Zone, Status fields to Metadata struct (ceilometer.go) - Emit binary, zone, status labels in genLabels() (main.go) - Increase pre-allocated label array size from 12 to 15 - Add volume.service.health test data to JSON test fixtures - Add genLabels unit test for volume service health labels Generated-By: Claude-Code claude-opus-4-6
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vyzigold The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
I'll leave it as draft until the ceilometer change merges https://review.opendev.org/c/openstack/ceilometer/+/983671 |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for parsing and exposing binary, zone, and status labels from ceilometer volume.service.health metrics in the sg-core ceilometer handler plugin. This ensures the Prometheus metrics exported by sg-core match the labels produced by ceilometer's built-in prometheus exporter.
Generated-By: Claude-Code claude-opus-4-6