Add CMake + vcpkg build#214
Open
pgleeson wants to merge 1 commit into
Open
Conversation
Tested on Windows.
Member
Author
|
@kant2002 Please have a look at this PR, which is now running GitHub actions tests. It seems some of your changes to the C++ are causing the tests to fail, e.g. See https://github.com/openworm/sibernetic/actions/runs/16505333248/job/46674341944 |
|
I know approximately what's going on. I would try to build on WSL in addition to Windows. Let's see how it look. Temporary I create #215 to check that functional code changes actually compile properly. They are useful by itself anyway. Once they land, may PR would be run automatically I assume and it would be easier for both of us, since I can catch this kind of errors myself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing changes to c++ with existing actions