🌱 Bump github.com/cert-manager/cert-manager from 1.19.4 to 1.20.0#2597
🌱 Bump github.com/cert-manager/cert-manager from 1.19.4 to 1.20.0#2597openshift-merge-bot[bot] merged 2 commits intooperator-framework:mainfrom
Conversation
Bumps [github.com/cert-manager/cert-manager](https://github.com/cert-manager/cert-manager) from 1.19.4 to 1.20.0. - [Release notes](https://github.com/cert-manager/cert-manager/releases) - [Changelog](https://github.com/cert-manager/cert-manager/blob/master/RELEASE.md) - [Commits](cert-manager/cert-manager@v1.19.4...v1.20.0) --- updated-dependencies: - dependency-name: github.com/cert-manager/cert-manager dependency-version: 1.20.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Todd Short <tshort@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Updates the operator-controller’s cert-manager integration to use cert-manager v1.20.0, adjusting code to match the updated cert-manager API types and refreshing Go module metadata accordingly.
Changes:
- Bump
github.com/cert-manager/cert-managerfromv1.19.4tov1.20.0. - Update
CertificateSpec.IssuerRefconstruction to usecertmanagermetav1.IssuerReference(wasObjectReference) in both implementation and tests. - Refresh
go.mod/go.sumto reflect transitive dependency updates (e.g.,gateway-api,miekg/dns,genprotosubmodule).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/operator-controller/rukpak/render/certproviders/certmanager.go | Adjusts cert-manager Certificate rendering to use the updated IssuerReference type with cert-manager v1.20.0. |
| internal/operator-controller/rukpak/render/certproviders/certmanager_test.go | Updates expected rendered Certificate spec to match the new IssuerReference type. |
| go.mod | Bumps cert-manager to v1.20.0 and updates indirect dependency versions pulled by the bump. |
| go.sum | Updates checksums for cert-manager and transitive dependency version changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tmshort
added
dependencies
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2597 +/- ##
==========================================
- Coverage 67.87% 67.85% -0.03%
==========================================
Files 137 137
Lines 9588 9588
==========================================
- Hits 6508 6506 -2
- Misses 2583 2584 +1
- Partials 497 498 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rashmigottipati, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit b240fef
into
operator-framework:main
Alternative to #2593 (fixes lint issues)
Bumps github.com/cert-manager/cert-manager from 1.19.4 to 1.20.0.
Description
Reviewer Checklist