Code Maintenance/STC-462: Resolve #activity-<journal-sequence> anchors on demand dropping eager journal lateral sequencing

[akabiru]

Ticket

https://community.openproject.org/wp/STC-462

This builds on:

• Feature/60875 Amend work package comment href from #activity-<journal-sequence> to #comment-<journal-id> #17721
• Code Maintenance/STC-462: Move work package activity tab from in-memory to database-level pagination #23434

What are you trying to accomplish?

Removes a ROW_NUMBER() OVER (...) JOIN LATERAL window function aka .with_sequence_version (~130ms/page on long histories) from the activity-tab's common render path. The legacy #activity-N anchor is now treated as a backwards-compatible alias and resolved lazily: when such a deep link arrives, the server resolves it to a journal id once, emits it as a resolved-comment-id Stimulus value, and the client canonicalises #activity-N → #comment- in the address bar.

On a work package with 702 journals, the page-slice query goes from ~130ms to a few ms:

--- Before — on every render:
  Journal Load (130.5ms)  SELECT * FROM journals
    JOIN LATERAL (
      SELECT journals_rank.id,
             ROW_NUMBER() OVER (ORDER BY version ASC) sequence_version
      FROM journals journals_rank
      WHERE journals_rank.journable_id   = journals.journable_id
        AND journals_rank.journable_type = journals.journable_type
    ) ranked ON ranked.id = journals.id
    WHERE … ORDER BY journals.created_at DESC, journals.id DESC LIMIT 20

--- After — same render, no window function:
  Journal Load (3.0ms)  SELECT journals.id, journals.journable_id, … FROM journals
    WHERE … ORDER BY journals.created_at DESC, journals.id DESC LIMIT 20

activity-N.mp4

Merge checklist

• Added/updated tests
• Added/updated documentation in Lookbook (patterns, previews, etc)
• Tested major browsers (Chrome, Firefox, Edge, ...)

[Copilot]

Pull request overview

Drops the ROW_NUMBER() OVER (...) JOIN LATERAL window-function join from the activity-tab's default render path. The legacy #activity-<sequence> URL is now treated as a backwards-compatible alias: when an activity-N anchor arrives, the server resolves it to a journal id once, exposes it as a Stimulus value (resolved-comment-id), and the client rewrites #activity-N to #comment-<id> in the address bar before scrolling. Journal item DOM no longer carries data-anchor-activity-id, only data-anchor-comment-id.

Changes:

• Paginator no longer applies with_sequence_version to the page slice; it only invokes the window function when an activity-N anchor needs resolution, and exposes the resolved comment id via a new resolved_anchor reader.
• Controller, lazy index component, and journal item templates are updated to drop the sequence_version join from the default path and surface resolved_anchor as a Stimulus value to the client.
• Frontend UrlHelpers.canonicalActivityAnchor and AutoScrollingController.canonicalizeActivityAnchor translate the legacy hash to the canonical comment hash via history.replaceState, with corresponding unit, request, and feature specs.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
app/services/work_packages/activities_tab/paginator.rb	Removes with_sequence_version from the page slice and records the resolved comment id only when an activity anchor is used.
app/controllers/work_packages/activities_tab_controller.rb	Forwards resolved_anchor to the lazy index component; drops with_sequence_version from find_journal and time-based update paths.
app/components/work_packages/activities_tab/lazy_index_component.rb	Accepts resolved_anchor and emits it as the resolved-comment-id Stimulus value when set.
app/components/.../journals/item_component(.html.erb, /details.rb)	Drops the now-unused data-anchor-activity-id DOM attribute.
frontend/.../services/url-helpers.ts (+ spec)	Adds canonicalActivityAnchor to map an unresolved or resolved activity anchor to a comment anchor.
frontend/.../auto-scrolling.controller.ts	Reads the new Stimulus value, canonicalises the URL hash via replaceState, and bails out when an activity anchor is unresolved.
spec/services/.../paginator_spec.rb	Asserts resolved_anchor semantics and that the window function is only run for activity anchors.
spec/requests/work_packages/activities_tab_spec.rb	New request spec covering the rendered Stimulus value attribute under all three anchor cases.
spec/features/.../activities_spec.rb	Adds a feature-level assertion that the URL is rewritten to #comment-<id> while preserving the work-package path.