[#26] Gemini structured output mimeType 값을 실제 API 요구사항에 맞춘다#27
Merged
Conversation
1ffab7e to
5250b59
Compare
There was a problem hiding this comment.
Code Review
This pull request updates the Gemini prediction client to use 'APPLICATION_JSON' instead of 'application/json' as the mimeType in the generation configuration, and updates the corresponding test assertions while removing the 'parses Gemini JSON text response' test. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🎯 의도
mimeTypeenum 값을 사용해 AI prediction 호출 실패를 해결하기 위한 수정📝 작업 내용
📌 요약
mimeType값을APPLICATION_JSON으로 변경🔍 상세
src/ai/geminiPredictionClient.ts에서generationConfig.responseFormat.text.mimeType값을"application/json"에서"APPLICATION_JSON"으로 변경tests/ai/geminiPredictionClient.test.ts에서 request payload 검증 값을"APPLICATION_JSON"으로 변경createDefaultAiPredictionClient성공 경로와 중복되던parses Gemini JSON text response테스트 제거generation_config.response_format.text.mime_typeinvalid argument 원인 반영📸 영상 / 이미지 (Optional)