-
Notifications
You must be signed in to change notification settings - Fork 10
fix(gleam): extract parameters for external functions #1127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+64
−1
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c7d5535
fix(gleam): extract parameters for external functions
carlos-alm 7dde2c3
test(gleam): exercise type-only external params with named-less args …
carlos-alm 9a09537
Merge branch 'main' into fix/1110-gleam-external-function-params
carlos-alm c6ee747
Merge branch 'main' into fix/1110-gleam-external-function-params
carlos-alm 30afdf1
Merge remote-tracking branch 'origin/main' into fix/1110-gleam-extern…
carlos-alm 482328b
Merge remote-tracking branch 'origin/main' into fix/1110-gleam-extern…
carlos-alm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test is named
'omits children for external functions with type-only parameters'and its Rust counterpart has the comment// External function with type-only parameters (no names), yet both userandom()— a function with zero parameters, not one with anonymous type-only params (e.g.random(Int, String)). These are structurally different tree nodes: an empty parameter list has no children at all, whereasrandom(Int, String)produces parameter nodes that simply lack anamefield. The PR description explicitly calls out "Type-only external params (nonamefield) are correctly omitted", but that code path is never exercised by either test suite.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 7dde2c3 — both the JS and Rust tests now use
random(Int, String)(type-only parameters with nonamefield) instead ofrandom()(zero parameters), so the assertion thatchildrenis undefined actually exercises the documented edge case: parameter nodes that exist in the tree but get filtered out byextractParams/extract_paramsbecause they lack anamefield.