-
Notifications
You must be signed in to change notification settings - Fork 12
docs: update query benchmarks (3.3.1) #548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fnDepsandfnImpactquery latencies have roughly doubled to tripled compared to 3.3.0:fnDepsd1fnDepsd3fnImpactd1Note that the hub target changed from
src/types.ts→buildGraphbetween versions. IfbuildGraphis a significantly denser node in the graph, part of this increase may be expected due to traversing a larger subgraph. However, if the benchmark is meant to track consistent performance across versions, the change in hub target makes the comparison not fully apples-to-apples. It's worth confirming whether this regression is intentional (larger graph, new node as hub) or a genuine performance degradation introduced in 3.3.1.The
diffImpactlatency did improve (8.8ms → 7ms native, 8.5ms → 4.8ms WASM), which is a positive signal.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acknowledged — the hub target changed from src/types.ts to buildGraph between versions, which is a significantly denser node (it orchestrates the full build pipeline). The latency increase is expected given the larger subgraph traversal. The benchmark script auto-selects the hub as the highest-degree node, so this is an artifact of the codebase growing rather than a genuine performance regression. The diffImpact improvement confirms the query engine itself is performing well.