feat(github-star): star prompt + first-run onboarding walkthrough#514
Open
beruro wants to merge 2 commits into
Open
feat(github-star): star prompt + first-run onboarding walkthrough#514beruro wants to merge 2 commits into
beruro wants to merge 2 commits into
Conversation
Coupled slice: the onboarding walkthrough emits the GitHub Star value moment, so the two ship together. - github-star: `integrations::github::star` commands (check_orgii_star, star_orgii) + `src/features/GitHubStar` (client, controller, reminder, settings row, prompt settings, localization) + typed `api/tauri/githubStar` + settings toggle (settingsSchema) + settings-namespace i18n (13 locales). - onboarding: `SetupWalkthrough` wizard + `SetupWalkthroughGuard` router guard + navigation helper + persisted `setupWalkthrough` setting; completion emits the GitHub Star value moment via `signalGitHubStarValueMoment`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Batched-split slice off latest
develop. Ships the GitHub Star value-moment feature together with the first-run onboarding walkthrough (they are coupled — the walkthrough emits the star value moment via@src/features/GitHubStar, so they cannot land independently).integrations::github::starRust commands (check_orgii_star,star_orgii) registered inhandler_list.inc;src/features/GitHubStar/*(client, controller, reminder, settings row, prompt settings, localization); typedapi/tauri/githubStar; a settings toggle +settingsi18n (13 locales).SetupWalkthroughwizard,SetupWalkthroughGuardrouter guard, navigation helper, and a persistedsetupWalkthroughsetting; completion emits the GitHub Star value moment.Notes
handler_list.incis included (team-inbox / file-index command registrations belong to other slices).Test plan
pnpm typecheck+pnpm exec vitest run src/features/GitHubStar src/router/guards src/store/settingscargo clippy -p integrations