chore: code quality improvements#174
Open
mikaello wants to merge 1 commit into
Open
Conversation
Contributor
mikaello
commented
Apr 4, 2026
mikaello
commented
- Fix bug in classNamesV3/classNamesV2: calling .javaClass on a Class<*> produced 'class' for every entry in error messages; use the Class directly instead
- Replace println error logging with IllegalArgumentException so callers get actionable feedback on mismatched element types
- Replace deprecated Jackson setSerializationInclusion with configOverride
- Remove unused java.lang.Class and java.net.URL imports
- Fix bug in classNamesV3/classNamesV2: calling .javaClass on a Class<*> produced 'class' for every entry in error messages; use the Class directly instead - Remove dead code in unmarshalGenericIofV2 (validateXml was hardcoded false with an unreachable V1 branch) - Remove dead code in unmarshalV2Xml (turnOfDtdValidation was hardcoded true with an unreachable else branch) - Replace println error logging with IllegalArgumentException so callers get actionable feedback on mismatched element types - Replace deprecated Jackson setSerializationInclusion with configOverride - Remove unused java.lang.Class and java.net.URL imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.