rabbitmq: honour the console_interface fallback

[ideaship]

osism/defaults resolves a node's internal address as

{{ hostvars[inventory_hostname]['ansible_' +
   internal_interface|default(console_interface)]['ipv4']['address'] }}

(defaults/manager/000-defaults.yml). The expression used here left the fallback out and referenced internal_interface directly, so a host that sets console_interface explicitly and leaves internal_interface unset — a configuration that resolves in the deployment — did not resolve here.

This adds the fallback so the two agree.

Where neither variable is set it still fails, and loudly: defaults/all/099-interfaces.yml defines console_interface: "{{ internal_interface|default(loopback0) }}", and loopback0 is not defined as a variable anywhere in osism/defaults (the name occurs only as an interface key in netplan and cloud-init files), so the lookup raises 'loopback0' is undefined rather than returning an address that was never configured.

Verification. On ansible-core 2.19.11, both the case this fixes (console_interface set to a real interface, internal_interface absent → resolves to that interface's address) and the case it must not paper over (neither set → raises).

Note this widens what resolves rather than narrowing it: the code preceding this stack required internal_interface outright and skipped the host without it.

Separable — this is not needed to fix osism/issues#1425, and can be deferred or dropped without affecting the rest of the stack.

🤖 Generated with Claude Code

[sourcery-ai]

Hey - I've left some high level feedback:

• The unit test that asserts internal_interface | default(console_interface) is present in INTERNAL_ADDRESS_EXPRESSION is somewhat brittle; consider instead validating the behavior via a small evaluation of the expression (or via the helper that uses it) so refactors of the string layout don’t break the test while preserving behavior.
• The Jinja expression string for INTERNAL_ADDRESS_EXPRESSION is now quite long and split across concatenated literals; you might consider using a single multi-line string or a helper builder function to improve readability and reduce the chance of subtle formatting mistakes in future changes.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The unit test that asserts `internal_interface | default(console_interface)` is present in `INTERNAL_ADDRESS_EXPRESSION` is somewhat brittle; consider instead validating the behavior via a small evaluation of the expression (or via the helper that uses it) so refactors of the string layout don’t break the test while preserving behavior.
- The Jinja expression string for `INTERNAL_ADDRESS_EXPRESSION` is now quite long and split across concatenated literals; you might consider using a single multi-line string or a helper builder function to improve readability and reduce the chance of subtle formatting mistakes in future changes.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}