Skip to content

changelog: add release notes for v0.20260808.0 - #2590

Merged
berendt merged 1 commit into
mainfrom
changelog/v0.20260808.0
Aug 8, 2026
Merged

changelog: add release notes for v0.20260808.0#2590
berendt merged 1 commit into
mainfrom
changelog/v0.20260808.0

Conversation

@berendt

@berendt berendt commented Aug 8, 2026

Copy link
Copy Markdown
Member

Fixes RabbitMQ node address resolution: interface fact keys with
dots (e.g. bond0.100) are preserved, resolution now goes through
Ansible host-context templating and a controller-side action
plugin, and console_interface is honoured as a fallback. Adds a
SONiC config-generation E2E golden test and RabbitMQ integration
tests wired into CI. Bumps sushy, next, eslint-config-next,
gitpython, and huey.

Generated with generate-changelog-input.sh using claude-sonnet-5.

Fixes RabbitMQ node address resolution: interface fact keys with
dots (e.g. bond0.100) are preserved, resolution now goes through
Ansible host-context templating and a controller-side action
plugin, and console_interface is honoured as a fallback. Adds a
SONiC config-generation E2E golden test and RabbitMQ integration
tests wired into CI. Bumps sushy, next, eslint-config-next,
gitpython, and huey.

Assisted-by: Claude:claude-sonnet-5
Signed-off-by: Christian Berendt <berendt@osism.tech>

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="CHANGELOG.md" line_range="17" />
<code_context>
+- Add integration tests validating RabbitMQ node interface resolution against real Ansible, wired into CI (osism/python-osism#2577)
+
+### Fixed
+- Rabbitmq node address lookup now keeps dots in interface fact keys instead of mangling them, fixing lookups for VLAN interfaces such as bond0.100 (osism/python-osism#2575)
+- Narrowed the secrets-file existence mock in rabbitmq tests so it no longer interferes with ansible's own file checks (osism/python-osism#2576)
+- Resolve RabbitMQ node internal_interface through Ansible host-context templating instead of a hand-written resolver, correctly handling all Jinja2 expression shapes (osism/python-osism#2578, osism/python-osism@9f78dc2)
</code_context>
<issue_to_address>
**issue (typo):** Correct "Rabbitmq" to "RabbitMQ" for consistent product naming.

This entry otherwise uses the correct "RabbitMQ" spelling, so please update this instance to match.

```suggestion
- RabbitMQ node address lookup now keeps dots in interface fact keys instead of mangling them, fixing lookups for VLAN interfaces such as bond0.100 (osism/python-osism#2575)
```
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread CHANGELOG.md
- Add integration tests validating RabbitMQ node interface resolution against real Ansible, wired into CI (osism/python-osism#2577)

### Fixed
- Rabbitmq node address lookup now keeps dots in interface fact keys instead of mangling them, fixing lookups for VLAN interfaces such as bond0.100 (osism/python-osism#2575)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (typo): Correct "Rabbitmq" to "RabbitMQ" for consistent product naming.

This entry otherwise uses the correct "RabbitMQ" spelling, so please update this instance to match.

Suggested change
- Rabbitmq node address lookup now keeps dots in interface fact keys instead of mangling them, fixing lookups for VLAN interfaces such as bond0.100 (osism/python-osism#2575)
- RabbitMQ node address lookup now keeps dots in interface fact keys instead of mangling them, fixing lookups for VLAN interfaces such as bond0.100 (osism/python-osism#2575)

@berendt
berendt merged commit 8495fbc into main Aug 8, 2026
4 checks passed
@berendt
berendt deleted the changelog/v0.20260808.0 branch August 8, 2026 19:26
@github-project-automation github-project-automation Bot moved this from New to Done in Human Board Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants