Redact sensitive values in verbose command logging#44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spawn helper redacts sensitive-looking option values when it builds error messages, but the framework component's verbose log printed the full command line as-is. Since the arguments include --param entries built from component inputs, where environment-resolved values typically end up, a verbose run could echo secrets into retained CI logs.
The redaction logic now lives in its own redact-args util, required by both the spawn helper and the framework component, and the verbose log line passes its arguments through it before printing. Extracting the helper rather than exporting it from the spawn module keeps the existing test stubs of the spawn module working untouched, and the redaction behaviour itself is unchanged, including its existing limitation that only recognisably sensitive option names are matched. The real values still reach the spawned process exactly as before; only the log line differs.