AO3-6395 Log Admin Banner Actions to Activities#5763
Open
caitlinkwan wants to merge 2 commits intootwcode:masterfrom
Open
AO3-6395 Log Admin Banner Actions to Activities#5763caitlinkwan wants to merge 2 commits intootwcode:masterfrom
caitlinkwan wants to merge 2 commits intootwcode:masterfrom
Conversation
marcus8448
suggested changes
May 8, 2026
Member
marcus8448
left a comment
marcus8448
left a comment
There was a problem hiding this comment.
Thanks for working on this!
Quick naming nit: we prefer action names to have spaces instead of underscores.
Member
There was a problem hiding this comment.
Admin activity is still being logged when the action/change fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-6395
Purpose
When an admin creates, updates, or deletes an admin banner, the action will be logged as an admin activity. The date, admin name, action, and target, and banner text is recorded.
Credit
caitlin (she/her)