feat: make Android tutor.yaml customizable via Tutor config (#48)#52
Conversation
Expose every customizable field of the Android app's tutor.yaml as
ANDROID_* Tutor settings (Firebase, Segment, Braze, Google, Microsoft,
Facebook, Branch, agreement URLs, discovery/program groups, feature
flags, etc.) so users can tweak them with `tutor config save --set`
instead of forking the template. Defaults match the previously
hardcoded values, so behavior is unchanged for existing users.
Add a `{{ patch("android-tutor-yaml") }}` hook at the end of the
rendered file so other Tutor plugins can append YAML or wholesale
replace a group; document the SnakeYAML last-value-wins behavior in
the README.
Closes #48
`twine check` was failing because the underline below the new "Customising the app configuration (``tutor.yaml``)" section title was 49 characters while the title itself is 50, which docutils rejects as "Title underline too short" and would break PyPI long_description rendering.
CodeWithEmad
left a comment
CodeWithEmad
left a comment
There was a problem hiding this comment.
LGTM. Makes the app more configurable. Does Edly have any plans to add a simple theming feature for this plugin?
Thanks for the review, @CodeWithEmad! 🙌 Yes, a simple theming feature is definitely something Edly is interested in, we agree it would be a great addition to the plugin. Unfortunately, due to current capacity constraints on our side, we're not able to pick it up ourselves in the near term and are looking for external contributors who could help drive it forward. If you have the bandwidth and interest, we'd really appreciate you taking a stab at it, happy to collaborate on it with you. Let us know! |
|
Cool! We can close this one for now. |
github-project-automation
Bot
moved this from In review
to Done
in Tutor project management
4 participants
Expose every customizable field of the Android app's tutor.yaml as ANDROID_* Tutor settings (Firebase, Segment, Braze, Google, Microsoft, Facebook, Branch, agreement URLs, discovery/program groups, feature flags, etc.) so users can tweak them with
tutor config save --setinstead of forking the template. Defaults match the previously hardcoded values, so behavior is unchanged for existing users.Add a
{{ patch("android-tutor-yaml") }}hook at the end of the rendered file so other Tutor plugins can append YAML or wholesale replace a group; document the SnakeYAML last-value-wins behavior in the README.Closes #48