feat: add TESTS filter#1387
Open
Danyal-Faheem wants to merge 14 commits into
Open
Conversation
Faraz32123
reviewed
May 22, 2026
Comment on lines
+635
to
+636
| yield ("lms", tests_teardown_lms_template(merged["SMOKE_USERNAME"])) | ||
| yield ("cms", tests_teardown_cms_template(merged["SMOKE_COURSE_ID"])) |
Contributor
There was a problem hiding this comment.
As TEST_DEFAULTS doesn't have SMOKE_USERNAME & SMOKE_COURSE_ID, can we make sure cleanup job doesn't fail with key error? Or I missed something?
Contributor
Author
There was a problem hiding this comment.
I was testing this with some smoke tests included and I removed them for the PR. I think I will add them to the PR itself which would make it easier to understand.
…MS ports - Add tutor/tests/smoke/ with test_lms, test_auth, test_users, test_enrollment, test_courses, conftest supporting LMS_PORT/CMS_PORT - Register smoke tests via TESTS filter in tutor/plugins/openedx.py using (service, suite, path) 3-tuples under lms/cms contexts - Fix SMOKE_TESTS_USERNAME/COURSE_ID → SMOKE_USERNAME/SMOKE_COURSE_ID key mismatch in TEST_DEFAULTS - Auto-inject LMS_PORT=8000/CMS_PORT=8001 in dev mode so tests reach the dev server directly without needing manual env var overrides - Add built-in smoke suite docs to platformtests.rst and run.rst Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ix cms signin redirect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1386.
We add the following changes:
TESTSFilter that will accumulate tests across tutor core and plugins.tutor local do tests [suite] --limit=<service>command to run tests across core and plugins. For example, to run smoke tests across plugins:tutor local do tests smokei. User Management and Authentication
ii. Course import, course creation
iii. User enrollment
iv. Basic healthchecks
v. OAuth Application creation