Skip to content

[FEATURE REQUEST] Take advantage of the search_min_length capability#4847

Open
joragua wants to merge 3 commits intomasterfrom
feature/search_min_length_capability
Open

[FEATURE REQUEST] Take advantage of the search_min_length capability#4847
joragua wants to merge 3 commits intomasterfrom
feature/search_min_length_capability

Conversation

@joragua
Copy link
Copy Markdown
Contributor

@joragua joragua commented May 8, 2026

Related Issues

App: #4789

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@joragua joragua self-assigned this May 8, 2026
@joragua joragua linked an issue May 8, 2026 that may be closed by this pull request
10 tasks
@joragua joragua marked this pull request as ready for review May 8, 2026 11:56
@joragua joragua requested a review from jesmrec May 8, 2026 11:56
Copy link
Copy Markdown
Contributor

@jesmrec jesmrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!! just a couple of comments @joragua

val capabilities = getStoredCapabilitiesUseCase(GetStoredCapabilitiesUseCase.Params(accountName = account.name))

val searchMinLength = capabilities?.filesSharingSearchMinLength ?: 3
if (userQuery.length < searchMinLength) { return MatrixCursor(COLUMNS) }
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you elaborate this line? return MatrixCursor(COLUMNS)


private var editMode = false
private var selectedMemberId = ""
private var searchMinLength = 3
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a constant by default, should it be moved to a companion object?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Take advantage of the search_min_length capability

2 participants