refactor: [DC-308] theme updates#12555
Draft
modSpike wants to merge 8 commits into
Draft
Conversation
hit the ones with no code deps first
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
just replace instance in code with aboutVersions which is essentially what the deprecated function did before
un-deprecate overrideServerUrl and get rid of overrideServerUrlV2
this should fix the squish tests
we decided the (c) should never appear on the settings panel (it was next to the "about" button) so this function is thereby obsolete Note, however, there was a strange side effect with the use of this in the gitSHA1 function: it effectively blocked turning the shortened sha into a url, and that url is important for oc "about" content. No idea what the "logic" was there but it's gone now. net == never any (c) on the settings page and sha can always be turned into a link if desired
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see https://kiteworks.atlassian.net/browse/DC-308