chore: add changelog for allow_subadmins setting full-ci#41636
Closed
phil-davis wants to merge 3 commits into
Closed
chore: add changelog for allow_subadmins setting full-ci#41636phil-davis wants to merge 3 commits into
phil-davis wants to merge 3 commits into
Conversation
…badmins The subadmin (group-admin) feature lets an admin delegate user management of specific groups to a non-admin user. The related code path has known security shortcomings, so the feature is now disabled by default as a risk-mitigation. Deployments that rely on it can opt back in by setting the new `allow_subadmins` system config to true. Enforcement is centralized in the OC\SubAdmin manager, the single chokepoint all consumers route through: - isSubAdmin() keeps the real-admin short-circuit, then returns false for group-admin-only users when disabled, cascading to permission bypasses, legacy guards and the settings middleware. - Read methods (isSubAdminofGroup, getSubAdminsGroups, getGroupsSubAdmins, getAllSubAdmins) behave as if no subadmins exist. - createSubAdmin throws HintException; the two write callers (togglesubadmins.php, provisioning_api addSubAdmin) surface a clean error. - deleteSubAdmin and the post-delete cleanup hooks stay enabled so admins can prune dormant assignments. The Users settings page hides the group-admin column when disabled, and the option is documented in config.sample.php with a security note. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a proposed changelog for #41634 and runs full-ci to confirm that all the API acceptance tests do pass.