docs: correct -s command-line flag description (7.1)#731
Open
DeepDiver1975 wants to merge 1 commit into
Open
Conversation
The `-s` / `--show` flag does not open a settings page. Per the owncloud/client v7.1.0 source (src/gui/main.cpp), it starts the Desktop App with the main window visible, or brings an already-running instance to the front. By default the client launches in the background. Closes #722 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
DeepDiver1975
commented
Jun 21, 2026
DeepDiver1975
left a comment
DeepDiver1975
left a comment
Member
Author
There was a problem hiding this comment.
🤖 Automated code review by Claude Code review agent
Verdict: Approve. Verified against upstream owncloud/client at tag v7.1.0 (matching the 7.1 docs line).
src/gui/main.cpp:123-125registers{{"s"},{"show"}}with help text: "Start with the main window visible, or if it is already running, bring it to the front. By default, the client launches in the background." The new description matches it, and adding the--showlong form is correct.- Old "settings page" wording was inaccurate for the flag's documented behavior.
- Scope docs-only (+1/-1); no broken AsciiDoc.
Pair consistency: 7.1 port of #732. baseRefName 7.1 (vs master); diffs identical. Consistent. Correctly uses Refs #722 while #732 carries Closes #722.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Corrects the description of the
-s/--showcommand-line flag ininstalling.adoc.The docs claimed the flag "forces the settings page to be displayed on startup". Per the
owncloud/clientv7.1.0 source (src/gui/main.cpp:123-125), the flag actually:Why
The previous wording was inaccurate — there is no "settings page" behavior for this flag.
Refs #722 (master PR carries the closing keyword).
🤖 Generated with Claude Code