docs: remove broken force-upload xref#734
Open
DeepDiver1975 wants to merge 1 commit into
Open
Conversation
The xref:force-uploading-conflicted-files[] link in conflicts.adoc pointed to an anchor that does not exist anywhere in the module, so Antora emitted a "target of xref not found" warning. The "Force Uploading Conflicted Files" feature is not documented in this branch. Drop the dangling link while keeping the sentence intact. Closes #723 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
DeepDiver1975
commented
Jun 21, 2026
DeepDiver1975
left a comment
Member
Author
There was a problem hiding this comment.
🤖 Automated code review by Claude Code review agent
Verdict: Approve. Verified on master.
- Searched the whole repo for
force-uploading-conflicted-files: the only match is the dangling xref line itself (conflicts.adoc:20). No section heading, no explicit[[force-uploading-conflicted-files]]anchor, and no matching attribute exists, so Antora would emit "target of xref not found". Removing the link is the right call given the feature is undocumented in this branch. - The surrounding sentence remains grammatical and complete after removal ("...have not been sent to the server.").
- Scope docs-only (+1/-1); no broken AsciiDoc.
Pair consistency: Paired with #733 (7.1); identical change, baseRefName master. Consistent.
Contributor
|
"conflict file uploading" is mentioned in https://github.com/owncloud/docs-client-desktop/blob/master/modules/ROOT/pages/using.adoc Maybe the feature has some different words to describe it, and maybe it is documented somewhere? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the dangling
xref:force-uploading-conflicted-files[Force Uploading Conflicted Files]link inconflicts.adoc:20.Why
No section, heading, or explicit anchor with the id
force-uploading-conflicted-filesexists anywhere in the module, so Antora emits a "target of xref not found" warning. The feature is not documented in this branch. The sentence remains intact without the dangling link.Closes #723
🤖 Generated with Claude Code