docs: use direct same-page xref for Ignored Files Editor#742
Merged
Conversation
DeepDiver1975
commented
Jun 21, 2026
DeepDiver1975
left a comment
DeepDiver1975
left a comment
Member
Author
There was a problem hiding this comment.
🤖 Automated code review by Claude Code review agent
Approve. Replaces the alias-routed xref with a direct same-page xref: xref:navigating.adoc#using-the-ignored-files-editor[...] → xref:using-the-ignored-files-editor[...].
- Verified the new target resolves: the heading
==== Using the Ignored Files Editorexists inusing.adoc(generated idusing-the-ignored-files-editor). - Confirmed
navigating.adocis only apage-aliasesentry ofusing.adocitself (:page-aliases: navigating.adoc), so the old form was a brittle self-alias route. The new form matches the already-correct same-page xref elsewhere in the file (xref:using-the-ignored-files-editor[see below]). - AsciiDoc syntax correct.
Pair consistency: identical diff to 7.1 companion #741, correct master base, Closes #727 carried here. LGTM.
phil-davis
approved these changes
Jun 22, 2026
The xref routed through `navigating.adoc#using-the-ignored-files-editor`, but `navigating.adoc` is only a page-aliases entry of using.adoc itself. This is a brittle self-referential link through the page's own alias. Replace it with a direct same-page xref, matching the existing correct reference elsewhere on the page (using.adoc:538). Closes #727 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
phil-davis
force-pushed
the
fix/727-ignored-files-xref
branch
from
b236910 to
debb759
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces the alias-routed xref at
using.adoc:630with a direct same-page xref:navigating.adoc#using-the-ignored-files-editor→using-the-ignored-files-editor.Why
navigating.adocis only apage-aliasesentry ofusing.adocitself, so this was a same-page link routed through the page's own alias — brittle and inconsistent. The target heading==== Using the Ignored Files Editor(using.adoc:570) exists. This matches the existing correct same-page xref atusing.adoc:538.Closes #727
🤖 Generated with Claude Code