chore(deps): drop unused direct dependency asciidoctor#182
Merged
Conversation
The standalone `asciidoctor` package was declared as a direct dependency but is never required or invoked anywhere in the project (no `require`, no CLI call in scripts/bin/CI). `asciidoctor-kroki` declares a peer dependency on `@asciidoctor/core >=2.2 <4.0`. Removing `asciidoctor` does not break that: npm still installs `@asciidoctor/core@3.0.4` at the top level to satisfy the peer, with no unmet-peer warnings, and kroki registers and converts diagrams correctly against it. Antora continues to use its own nested `@asciidoctor/core@2.2.9` for rendering. Verified in an isolated worktree: install drops from 408 to 343 packages (65 fewer) with no peer-dependency breakage. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
kw-tmueller
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the standalone
asciidoctorpackage fromdependencies.Why
asciidoctoris declared as a direct dependency but is never used — there is norequire('asciidoctor')/require('@asciidoctor/core')in any source file, and noasciidoctorCLI invocation inscripts,bin/, or CI.It originally appeared to be needed because
asciidoctor-krokihas a peer dependency on@asciidoctor/core >=2.2 <4.0. It turns out it isn't: npm satisfies that peer directly.Verification
Tested in an isolated worktree with a clean
npm install:asciidoctorasciidoctor@asciidoctor/core@3.0.4presentAntora keeps using its own nested
@asciidoctor/core@2.2.9for rendering;asciidoctor-krokibinds to the hoisted@asciidoctor/core@3.0.4, which npm installs to satisfy the peer dependency even without the top-levelasciidoctorpackage.package-lock.jsonis regenerated accordingly (prunesasciidoctorand its now-orphaned transitives:ejs,nunjucks,pug,@asciidoctor/cli).🤖 Generated with Claude Code