Skip to content

chore(deps): drop unused direct dependency asciidoctor#182

Merged
DeepDiver1975 merged 1 commit into
masterfrom
chore/drop-unused-asciidoctor-dep
Jun 22, 2026
Merged

chore(deps): drop unused direct dependency asciidoctor#182
DeepDiver1975 merged 1 commit into
masterfrom
chore/drop-unused-asciidoctor-dep

Conversation

@DeepDiver1975

Copy link
Copy Markdown
Member

What

Removes the standalone asciidoctor package from dependencies.

Why

asciidoctor is declared as a direct dependency but is never used — there is no require('asciidoctor') / require('@asciidoctor/core') in any source file, and no asciidoctor CLI invocation in scripts, bin/, or CI.

It originally appeared to be needed because asciidoctor-kroki has a peer dependency on @asciidoctor/core >=2.2 <4.0. It turns out it isn't: npm satisfies that peer directly.

Verification

Tested in an isolated worktree with a clean npm install:

with asciidoctor without asciidoctor
packages installed 408 343 (−65)
@asciidoctor/core@3.0.4 present ✓ (hoisted for kroki peer)
unmet-peer warnings none none
kroki register + convert PlantUML

Antora keeps using its own nested @asciidoctor/core@2.2.9 for rendering; asciidoctor-kroki binds to the hoisted @asciidoctor/core@3.0.4, which npm installs to satisfy the peer dependency even without the top-level asciidoctor package.

Note: a full npm run antora build could not be run in the test environment (Node v18 vs. Antora's undici requiring Node ≥20.18.1 — unrelated to this change). The peer-dependency resolution and runtime kroki conversion are the conclusive signals.

package-lock.json is regenerated accordingly (prunes asciidoctor and its now-orphaned transitives: ejs, nunjucks, pug, @asciidoctor/cli).

🤖 Generated with Claude Code

The standalone `asciidoctor` package was declared as a direct dependency
but is never required or invoked anywhere in the project (no `require`,
no CLI call in scripts/bin/CI).

`asciidoctor-kroki` declares a peer dependency on
`@asciidoctor/core >=2.2 <4.0`. Removing `asciidoctor` does not break
that: npm still installs `@asciidoctor/core@3.0.4` at the top level to
satisfy the peer, with no unmet-peer warnings, and kroki registers and
converts diagrams correctly against it. Antora continues to use its own
nested `@asciidoctor/core@2.2.9` for rendering.

Verified in an isolated worktree: install drops from 408 to 343
packages (65 fewer) with no peer-dependency breakage.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
@DeepDiver1975 DeepDiver1975 merged commit 1fc1e66 into master Jun 22, 2026
2 checks passed
@DeepDiver1975 DeepDiver1975 deleted the chore/drop-unused-asciidoctor-dep branch June 22, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants