Skip to content

Add HubrisArchive::load_from_path #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
labbott wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −0
Open

Add HubrisArchive::load_from_path #674

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d41ea7
Add `HubrisArchive::load_from_path`
labbott May 21, 2026
47b0efa
Merge branch 'master' into labbott/load_from_path
labbott May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions humility-core/src/hubris.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1336,6 +1336,13 @@ impl HubrisArchive {
inlined
}

pub fn load_from_path<P: AsRef<Path> + std::fmt::Debug + Copy>(
Copy link
Copy Markdown
Contributor Author

@labbott labbott May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter was borrowed from hubtools, certainly open to suggestions

Copy link
Copy Markdown
Contributor

@mkeeter mkeeter May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm the person who wrote them in hubtools, but cannot fathom why I added Copy as a bound here. I opened oxidecomputer/hubtools#66

path: P,
) -> Result<Self> {
let hubris = RawHubrisArchive::load(path)?;
Self::load(hubris, None)
}

pub fn load(
hubris: RawHubrisArchive,
task_dump: Option<DumpTask>,
Expand Down
Loading