implement RFD 689#10472
Draft
rcgoodfellow wants to merge 9 commits into
Draft
Conversation
rcgoodfellow
commented
May 22, 2026
| dhcp_config: DhcpCfg::default(), | ||
| // Services do not use attached subnets, only instances. | ||
| attached_subnets: vec![], | ||
| // TODO(RFD 689): plumb the fleet-wide jumbo-frames opt-in |
Contributor
Author
There was a problem hiding this comment.
Note to self: make follow up issue for this.
rcgoodfellow
commented
May 22, 2026
| curl -fL -o "$P5P_PATH" "$P5P_URL" | ||
|
|
||
| RC=0 | ||
| pfexec pkg install -g "$P5P_PATH" driver/network/opte || RC=$? |
Contributor
Author
There was a problem hiding this comment.
This pattern was not working for me in a4x2 with Helios 3. The new form does work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the Omicron side of RFD 689.
Depends on: