Add system-version to omdb db #10481
Open
emunn13 wants to merge 4 commits into
Open
Conversation
…his version update was requested
karencfv
reviewed
May 22, 2026
Contributor
karencfv
left a comment
karencfv
left a comment
There was a problem hiding this comment.
This is great! Thanks for working on this command.
Comment on lines
+409
to
+410
| /// Print the current target system release and the update date (print all of the releases when `--all` is present) | ||
| SystemVersion(system_version::SystemVersionArgs), |
Contributor
There was a problem hiding this comment.
Not all components may be at the target release version at any given time. Having a "system-version" command could be confusing. It's probably more accurate to call it "target-release" :)
Author
There was a problem hiding this comment.
Thanks so much for the review, appreciate it :) I've changed it to target-release.
wfchandler
reviewed
May 22, 2026
| Sleds(SledsArgs), | ||
| /// Show instances grouped by the sled they are running on | ||
| SledInstances(SledInstancesArgs), | ||
| /// Print the current target system release and the update date (print all of the releases when `--all` is present) |
Contributor
There was a problem hiding this comment.
We typically don't mention command flags in the doc string.
Author
|
Tested the generated binary on dogfood: omdb db target-releaseomdb db target-release --all |
…ga and omdb nexus blueprints list
Author
|
Tested latest commit (dd347a4) on dogfood. Newest record at the bottom. omdb db target-release --allomdb db target-release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
system-versionsubcommand toomdb dbto print the current system version and when this version update was requested.Also add
--all, to print all system versions and their requested dates.