Skip to content

[nexus] fix semantic merge conflict between #10787 and #10801#10860

Merged
hawkw merged 1 commit into
mainfrom
eliza/merge-10801-and-10787
Jul 17, 2026
Merged

[nexus] fix semantic merge conflict between #10787 and #10801#10860
hawkw merged 1 commit into
mainfrom
eliza/merge-10801-and-10787

Conversation

@hawkw

@hawkw hawkw commented Jul 17, 2026

Copy link
Copy Markdown
Member

PR #10801 changed one of the arguments to
instance_updater_inherit_lock to be passed as a reference, and #10787 added a new test that calls that function. I branched #10801 from main prior to #10787 merging, so the & was never added where it needed to be. Hilarity ensues. :(

PR #10801 changed one of the arguments to
`instance_updater_inherit_lock` to be passed as a reference, and #10787
added a new test that calls that function. I branched #10801 from `main`
prior to #10787 merging, so the `&` was never added where it needed to
be. Hilarity insues. :(
@hawkw
hawkw requested a review from sunshowers July 17, 2026 21:03
@hawkw
hawkw enabled auto-merge (squash) July 17, 2026 21:04
@hawkw
hawkw disabled auto-merge July 17, 2026 21:05
@hawkw
hawkw enabled auto-merge (squash) July 17, 2026 21:05
@hawkw
hawkw disabled auto-merge July 17, 2026 21:12
@hawkw
hawkw enabled auto-merge (squash) July 17, 2026 21:12
@hawkw
hawkw merged commit 2272cf2 into main Jul 17, 2026
19 checks passed
@hawkw
hawkw deleted the eliza/merge-10801-and-10787 branch July 17, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants