Validate the full standard examples corpus in CI - #81
Merged
Conversation
pals-project/pals#285 grew the standard's examples/ into a corpus of example machines and unit-test lattices. Validate all of it: every *.pals.yaml is discovered automatically and must be readable with pals.load() (*.subpals.yaml include fragments are exempt), keeping the structural spot-checks for fodo.pals.yaml. The files this implementation cannot read yet are recorded in tests/standard_examples_known_failures.txt, grouped by cause, to be resolved in follow-up PRs; a listed file that starts to load is reported so the list only shrinks. The standard is checked out at a pinned commit (tests/pals_standard_ref.txt) so changes to it cannot break unrelated PRs; a weekly_update workflow, modeled on WarpX's, bumps the pin to the current pals main in a controlled PR of its own. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
EZoni
reviewed
Jul 30, 2026
EZoni
reviewed
Jul 30, 2026
EZoni
reviewed
Jul 30, 2026
Member
There was a problem hiding this comment.
For this file maybe, now or in the future, a TOML format could be useful in case we want to add metadata to the failures, e.g.,
["machine/machine.pals.yaml"]
reason = "Facility-level includes are not resolved"
issue = 123
Member
Author
There was a problem hiding this comment.
Yeah. But also our goal is that this file is empty when we are done :D
I hope we will not have to permanently exclude files
ax3l
force-pushed
the
standard-examples-corpus
branch
from
July 30, 2026 22:00
a851238 to
6d28297
Compare
EZoni
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pals-project/pals#285 grew the standard's
examples/into a corpus of example machines and unit-test lattices. Validate all of it: every*.pals.yamlis discovered automatically and must be readable withpals.load()(*.subpals.yamlinclude fragments are exempt), keeping the structural spot-checks forfodo.pals.yaml. The files this implementation cannot read yet are recorded intests/standard_examples_known_failures.txt, grouped by cause, to be resolved in follow-up PRs. A therein listed file that starts to load is reported so the list only shrinks.The standard is checked out at a pinned commit (
tests/pals_standard_ref.txt) so changes to it cannot break unrelated PRs. As in WarpX, aweekly_updateworkflow, bumps the pin to the current pals main in a controlled PR of its own.Similar PR in
pals-cpp: pals-project/pals-cpp#89