Skip to content

✨ feat: Adds RFD tag for github contrib#29

Merged
jpmcb merged 1 commit into
mainfrom
rfd-gitcheck
May 12, 2026
Merged

✨ feat: Adds RFD tag for github contrib#29
jpmcb merged 1 commit into
mainfrom
rfd-gitcheck

Conversation

@jpmcb
Copy link
Copy Markdown
Contributor

@jpmcb jpmcb commented May 12, 2026

For a ✏️ RFD: github PR. Related to: https://github.com/papercomputeco/engineering/pull/7

Refs PCC-516

@jpmcb jpmcb requested a review from a team May 12, 2026 21:22
@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 12, 2026

PCC-516

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented May 12, 2026

Greptile Summary

This PR adds ✏️ RFD: ("Request for Discussion") as a new valid PR title prefix in both the Go validation logic and the README documentation.

  • ghcontrib/pr.go: Appends "✏️ RFD: " to validPRPrefixes; all other prefix types also carry a colon-based counterpart in that slice, but no :pencil2: RFD: entry was added.
  • ghcontrib/README.md: Documents the new prefix alongside the existing ones.

Confidence Score: 4/5

Safe to merge; the only gap is a missing colon-based alias for the new RFD prefix.

The change is small and correct — the literal-emoji RFD prefix works as intended. The colon-based variant (:pencil2: RFD: ) was not added, unlike every other prefix type, so users who write titles that way will get a false validation failure until it is added.

ghcontrib/pr.go — the colon-based emoji section should include a :pencil2: RFD: entry to match the convention established by all other prefixes.

Important Files Changed

Filename Overview
ghcontrib/pr.go Adds "✏️ RFD: " to validPRPrefixes; missing colon-based derivative (:pencil2: RFD: ) that all other prefix types provide.
ghcontrib/README.md Documents the new ✏️ RFD: prefix, consistent with the code change.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR Title] --> B{HasPrefix check}
    B -->|"✨ feat: "| V[✅ Valid]
    B -->|"🔧 fix: "| V
    B -->|"🧹 chore: "| V
    B -->|"♻️ refactor: "| V
    B -->|"🎨 design: "| V
    B -->|"📚 docs: "| V
    B -->|"✏️ RFD: " ✨NEW| V
    B -->|":sparkles: feat: "| V
    B -->|":wrench: fix: "| V
    B -->|":broom: chore: "| V
    B -->|":recycle: refactor: "| V
    B -->|":art: design: "| V
    B -->|":books: docs: "| V
    B -->|":pencil2: RFD: " ❌MISSING| X[❌ Invalid - no match]
    B -->|no match| X
Loading

Comments Outside Diff (1)

  1. ghcontrib/pr.go, line 22-28 (link)

    P2 Every other prefix type has a colon-based emoji derivative (e.g. ":sparkles: feat: " alongside "✨ feat: "). The new RFD prefix is missing its colon counterpart — a PR titled :pencil2: RFD: ... will fail validation even though the same convention works for all other types.

    Prompt To Fix With AI
    This is a comment left during a code review.
    Path: ghcontrib/pr.go
    Line: 22-28
    
    Comment:
    Every other prefix type has a colon-based emoji derivative (e.g. `":sparkles: feat: "` alongside `"✨ feat: "`). The new RFD prefix is missing its colon counterpart — a PR titled `:pencil2: RFD: ...` will fail validation even though the same convention works for all other types.
    
    
    
    How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
ghcontrib/pr.go:22-28
Every other prefix type has a colon-based emoji derivative (e.g. `":sparkles: feat: "` alongside `"✨ feat: "`). The new RFD prefix is missing its colon counterpart — a PR titled `:pencil2: RFD: ...` will fail validation even though the same convention works for all other types.

```suggestion
	// Colon based emoji derivatives
	":sparkles: feat: ",
	":wrench: fix: ",
	":broom: chore: ",
	":recycle: refactor: ",
	":art: design: ",
	":books: docs: ",
	":pencil2: RFD: ",
```

Reviews (1): Last reviewed commit: "✨ feat: Adds RFD tag for github contrib" | Re-trigger Greptile

Signed-off-by: John McBride <john@papercompute.com>
Copy link
Copy Markdown
Contributor

@yeazelm yeazelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 🚢

@jpmcb jpmcb merged commit 794b341 into main May 12, 2026
4 checks passed
@jpmcb jpmcb deleted the rfd-gitcheck branch May 13, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants