Skip to content

feat!: remove bundled entrypoint (pfe.min.js)#3089

Merged
bennypowers merged 3 commits intostaging/pfe5from
fix/remove-bundled-entrypoint
Apr 23, 2026
Merged

feat!: remove bundled entrypoint (pfe.min.js)#3089
bennypowers merged 3 commits intostaging/pfe5from
fix/remove-bundled-entrypoint

Conversation

@bennypowers
Copy link
Copy Markdown
Member

Summary

Remove the bundled entrypoint (pfe.min.js) from @patternfly/elements.

  • Remove main field and . export pointing to pfe.min.js from elements/package.json
  • Remove build:bundle wireit config and dependency from root package.json
  • Delete scripts/bundle.js

The bundled entrypoint caused custom element double-registration issues
and is not recommended for production use. Import individual elements directly instead.

See #2960 for context.

Closes #3087

Test plan

  • npm run build succeeds without build:bundle
  • Package exports still work for individual element imports

The bundled entrypoint causes custom element double-registration
issues and is not the recommended way to consume the library.

Closes #3087

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 15, 2026

🦋 Changeset detected

Latest commit: e9bc40b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@patternfly/elements Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 15, 2026

✅ Commitlint tests passed!

More Info
{
  "valid": true,
  "errors": [],
  "warnings": [],
  "input": "feat!: remove bundled entrypoint (pfe.min.js)"
}

@github-actions github-actions Bot added the AT passed Automated testing has passed label Apr 15, 2026
Remove the bundle() call and pfe.min.* passthrough copies
from the Eleventy docs plugin, since the bundled entrypoint
was removed.

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 15, 2026

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 4935995
😎 Deploy Preview https://deploy-preview-3089--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Copy Markdown
Contributor

SSR Test Run for 351cf2b: Report

Fixes padded-blocks lint error.

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

SSR Test Run for 4935995: Report

@bennypowers bennypowers merged commit 25f2617 into staging/pfe5 Apr 23, 2026
12 checks passed
@bennypowers bennypowers deleted the fix/remove-bundled-entrypoint branch April 23, 2026 13:19
bennypowers added a commit that referenced this pull request Apr 29, 2026
* feat!: rename all elements to pf-v5-* prefix

Rename all 35 elements and their sub-components from pf-* to pf-v5-*.
CSS custom properties renamed from --pf-c-* to --pf-v5-c-*.
Global tokens (--pf-global--*) are unchanged.

Closes #3052, closes #3053, closes #3054, closes #3055,
closes #3056, closes #3057, closes #3058, closes #3059,
closes #3060, closes #3061, closes #3062, closes #3063,
closes #3064, closes #3065, closes #3066, closes #3067,
closes #3068, closes #3069, closes #3070, closes #3071,
closes #3072, closes #3073, closes #3074, closes #3075,
closes #3076, closes #3077, closes #3078, closes #3079,
closes #3080, closes #3081, closes #3082, closes #3083,
closes #3084, closes #3085, closes #3086

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* feat!: remove bundled entrypoint (pfe.min.js) (#3089)

* feat!: remove bundled entrypoint (pfe.min.js)

The bundled entrypoint causes custom element double-registration
issues and is not the recommended way to consume the library.

Closes #3087

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: remove bundle references from docs plugin

Remove the bundle() call and pfe.min.* passthrough copies
from the Eleventy docs plugin, since the bundled entrypoint
was removed.

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: remove trailing blank line in pfe-assets plugin

Fixes padded-blocks lint error.

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* docs: update element references from pf-* to pf-v5-*

Update all docs site references to use the new pf-v5-* element names,
including HTML tags, CSS selectors, import paths, and code examples.

Blog posts and changelogs left unchanged as historical records.
PF4 core CSS tokens (--pf-c-content/title/text) left unchanged as
they reference the PF CSS framework, not pf-elements components.

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(docs): fix docs build after pf-v5-* rename

- Update main.mjs to import PfV5Icon from renamed path
- Update pfe-assets.cjs regex and JSDoc for pf-v5-* paths
- Pass prefix option to PfeAssetsPlugin in eleventy config
- Replace broken generateImportMap shortcodes with static import
  maps (jspm.io can't resolve unpublished pf-v5-* paths)
- Fix pre-existing TS build errors: use Router.Middleware instead
  of non-existent RouterMiddleware export, remove stale
  @ts-expect-error directive
- Fix pre-existing slug function call using deprecated
  eleventyConfig.javascript.functions API

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* feat!: remove deprecated APIs (#3090)

- Remove CascadeController and @Cascades decorator (use @lit/context)
- Remove SlotController.anonymous (use SlotController.default)
- Remove pf-popover closeButtonLabel / close-label attribute
  (use accessible-close-label)

pfeCustomElementsManifestConfig was already removed from the codebase.

Closes #2975, closes #2974, closes #2973, closes #2972

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(tools): fix TS build errors on CI

- Use koa Middleware type instead of Router.Middleware namespace
  (namespace not available with Node moduleResolution)
- Use @ts-ignore instead of @ts-expect-error for colorjs.io import
  (error occurs on CI but not locally due to moduleResolution)

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(docs): handle ESM default export from slugify v2

`@sindresorhus/slugify` v2 is ESM-only. Node 22 `require()` of ESM
returns the module namespace object, not the default export, causing
`TypeError: slugify is not a function` in the eleventy `ids` transform.

Assisted-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

* chore: clean up remaining pf-* references after rename

- README: update test path examples to pf-v5-* element dirs
- elements/package.json: remove orphaned pf-jazz-hands export entry
- eslint.config.js: fix pf-icon ignore path to pf-v5-icon
- bundle.ts: update pf-icon export to pf-v5-icon
- dev server index.html template: update pf-button/pf-icon/pf-card tags
  and imports to pf-v5-* equivalents
- docs/_snippets: update accordion-jsx and card-html import paths
- vue.md: fix CodeSandbox search hint to @patternfly/elements

Assisted-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

* fix: tools and docs for pf-v5 prefix/ elements rename compatibility (#3114)

* docs: rename doc files to match pf-v5 element names

* chore: update tagPrefix in config

* fix: use unbundled element modules for docs site

* refactor(tools): use pfe config for tag aliasing in DocsPage

* chore(tools): add changeset

* chore: correct npm run docs to include the elements build

* fix: copy element screenshots to docs site

* fix: copy demo assets to docs site

* fix: strip v5 prefix from docs titles, replace jspm with mappa (#3115)

* fix: strip v5 prefix from docs titles, replace @jspm/generator with @pwrs/mappa

Strip the tag prefix (pf-v5-) from element display names in the docs
site sidebar, page titles, and demo headings so they show "Accordion"
instead of "V5 Accordion".

Replace @jspm/generator with @pwrs/mappa for import map generation in
both the 11ty docs build and the dev server plugin. This fixes the
"Unable to resolve npm:lit@3.3.2" build error and simplifies the import
map infrastructure.

Also adds v5 to the docs version dropdown and marks it as current.

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: remove stale @jspm/generator patch file

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: lint errors in create-import-map and package.json sort order

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: operator-linebreak style in create-import-map

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Benny Powers <web@bennypowers.com>
Co-authored-by: Benny Powers <bennypowers@users.noreply.github.com>
bennypowers added a commit that referenced this pull request May 6, 2026
* feat!: remove bundled entrypoint (pfe.min.js)

The bundled entrypoint causes custom element double-registration
issues and is not the recommended way to consume the library.

Closes #3087

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: remove bundle references from docs plugin

Remove the bundle() call and pfe.min.* passthrough copies
from the Eleventy docs plugin, since the bundled entrypoint
was removed.

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: remove trailing blank line in pfe-assets plugin

Fixes padded-blocks lint error.

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bennypowers added a commit that referenced this pull request May 6, 2026
* feat!: remove bundled entrypoint (pfe.min.js)

The bundled entrypoint causes custom element double-registration
issues and is not the recommended way to consume the library.

Closes #3087

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: remove bundle references from docs plugin

Remove the bundle() call and pfe.min.* passthrough copies
from the Eleventy docs plugin, since the bundled entrypoint
was removed.

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: remove trailing blank line in pfe-assets plugin

Fixes padded-blocks lint error.

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants