feat!: remove deprecated APIs by bennypowers · Pull Request #3090 · patternfly/patternfly-elements

bennypowers · 2026-04-15T12:28:03Z

Summary

Remove CascadeController and @cascades decorator -- use @lit/context instead
Remove SlotController.anonymous -- use SlotController.default instead
Remove pf-popover closeButtonLabel property and close-label attribute -- use accessible-close-label instead
pfeCustomElementsManifestConfig was already removed from the codebase; closing Remove deprecated pfeCustomElementsManifestConfig from pfe-tools #2975 for tracking

Test plan

Verify no remaining references to removed APIs
Verify pf-popover close button still works with accessible-close-label
Verify SlotController still works with SlotController.default

@Cascades

- Remove CascadeController and @Cascades decorator (use @lit/context) - Remove SlotController.anonymous (use SlotController.default) - Remove pf-popover closeButtonLabel / close-label attribute (use accessible-close-label) pfeCustomElementsManifestConfig was already removed from the codebase. Closes #2975, closes #2974, closes #2973, closes #2972 Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

changeset-bot · 2026-04-15T12:28:06Z

🦋 Changeset detected

Latest commit: 4c02b1e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@patternfly/pfe-core	Major
@patternfly/elements	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2026-04-15T12:28:57Z

✅ Commitlint tests passed!

More Info

{
  "valid": true,
  "errors": [],
  "warnings": [],
  "input": "feat!: remove deprecated APIs"
}

github-actions · 2026-04-15T12:29:55Z

✅ Deploy Preview for patternfly-elements ready!

Name	Link
🔨 Latest commit	`5556957`
😎 Deploy Preview	https://deploy-preview-3090--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions · 2026-04-15T12:30:30Z

SSR Test Run for 5556957: Report

@ts-expect-error

* feat!: rename all elements to pf-v5-* prefix Rename all 35 elements and their sub-components from pf-* to pf-v5-*. CSS custom properties renamed from --pf-c-* to --pf-v5-c-*. Global tokens (--pf-global--*) are unchanged. Closes #3052, closes #3053, closes #3054, closes #3055, closes #3056, closes #3057, closes #3058, closes #3059, closes #3060, closes #3061, closes #3062, closes #3063, closes #3064, closes #3065, closes #3066, closes #3067, closes #3068, closes #3069, closes #3070, closes #3071, closes #3072, closes #3073, closes #3074, closes #3075, closes #3076, closes #3077, closes #3078, closes #3079, closes #3080, closes #3081, closes #3082, closes #3083, closes #3084, closes #3085, closes #3086 Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat!: remove bundled entrypoint (pfe.min.js) (#3089) * feat!: remove bundled entrypoint (pfe.min.js) The bundled entrypoint causes custom element double-registration issues and is not the recommended way to consume the library. Closes #3087 Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: remove bundle references from docs plugin Remove the bundle() call and pfe.min.* passthrough copies from the Eleventy docs plugin, since the bundled entrypoint was removed. Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: remove trailing blank line in pfe-assets plugin Fixes padded-blocks lint error. Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * docs: update element references from pf-* to pf-v5-* Update all docs site references to use the new pf-v5-* element names, including HTML tags, CSS selectors, import paths, and code examples. Blog posts and changelogs left unchanged as historical records. PF4 core CSS tokens (--pf-c-content/title/text) left unchanged as they reference the PF CSS framework, not pf-elements components. Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix(docs): fix docs build after pf-v5-* rename - Update main.mjs to import PfV5Icon from renamed path - Update pfe-assets.cjs regex and JSDoc for pf-v5-* paths - Pass prefix option to PfeAssetsPlugin in eleventy config - Replace broken generateImportMap shortcodes with static import maps (jspm.io can't resolve unpublished pf-v5-* paths) - Fix pre-existing TS build errors: use Router.Middleware instead of non-existent RouterMiddleware export, remove stale @ts-expect-error directive - Fix pre-existing slug function call using deprecated eleventyConfig.javascript.functions API Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat!: remove deprecated APIs (#3090) - Remove CascadeController and @Cascades decorator (use @lit/context) - Remove SlotController.anonymous (use SlotController.default) - Remove pf-popover closeButtonLabel / close-label attribute (use accessible-close-label) pfeCustomElementsManifestConfig was already removed from the codebase. Closes #2975, closes #2974, closes #2973, closes #2972 Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix(tools): fix TS build errors on CI - Use koa Middleware type instead of Router.Middleware namespace (namespace not available with Node moduleResolution) - Use @ts-ignore instead of @ts-expect-error for colorjs.io import (error occurs on CI but not locally due to moduleResolution) Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix(docs): handle ESM default export from slugify v2 `@sindresorhus/slugify` v2 is ESM-only. Node 22 `require()` of ESM returns the module namespace object, not the default export, causing `TypeError: slugify is not a function` in the eleventy `ids` transform. Assisted-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> * chore: clean up remaining pf-* references after rename - README: update test path examples to pf-v5-* element dirs - elements/package.json: remove orphaned pf-jazz-hands export entry - eslint.config.js: fix pf-icon ignore path to pf-v5-icon - bundle.ts: update pf-icon export to pf-v5-icon - dev server index.html template: update pf-button/pf-icon/pf-card tags and imports to pf-v5-* equivalents - docs/_snippets: update accordion-jsx and card-html import paths - vue.md: fix CodeSandbox search hint to @patternfly/elements Assisted-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> * fix: tools and docs for pf-v5 prefix/ elements rename compatibility (#3114) * docs: rename doc files to match pf-v5 element names * chore: update tagPrefix in config * fix: use unbundled element modules for docs site * refactor(tools): use pfe config for tag aliasing in DocsPage * chore(tools): add changeset * chore: correct npm run docs to include the elements build * fix: copy element screenshots to docs site * fix: copy demo assets to docs site * fix: strip v5 prefix from docs titles, replace jspm with mappa (#3115) * fix: strip v5 prefix from docs titles, replace @jspm/generator with @pwrs/mappa Strip the tag prefix (pf-v5-) from element display names in the docs site sidebar, page titles, and demo headings so they show "Accordion" instead of "V5 Accordion". Replace @jspm/generator with @pwrs/mappa for import map generation in both the 11ty docs build and the dev server plugin. This fixes the "Unable to resolve npm:lit@3.3.2" build error and simplifies the import map infrastructure. Also adds v5 to the docs version dropdown and marks it as current. Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: remove stale @jspm/generator patch file Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: lint errors in create-import-map and package.json sort order Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: operator-linebreak style in create-import-map Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Benny Powers <web@bennypowers.com> Co-authored-by: Benny Powers <bennypowers@users.noreply.github.com>

@Cascades

- Remove CascadeController and @Cascades decorator (use @lit/context) - Remove SlotController.anonymous (use SlotController.default) - Remove pf-popover closeButtonLabel / close-label attribute (use accessible-close-label) pfeCustomElementsManifestConfig was already removed from the codebase. Closes #2975, closes #2974, closes #2973, closes #2972 Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

@Cascades

- Remove CascadeController and @Cascades decorator (use @lit/context) - Remove SlotController.anonymous (use SlotController.default) - Remove pf-popover closeButtonLabel / close-label attribute (use accessible-close-label) pfeCustomElementsManifestConfig was already removed from the codebase. Closes #2975, closes #2974, closes #2973, closes #2972 Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

github-actions Bot added the AT passed Automated testing has passed label Apr 15, 2026

bennypowers requested a review from zeroedin April 23, 2026 13:14

zeroedin approved these changes Apr 23, 2026

View reviewed changes

bennypowers merged commit a8a623c into staging/pfe5 Apr 23, 2026
12 checks passed

bennypowers deleted the feat/remove-deprecated-apis branch April 23, 2026 14:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat!: remove deprecated APIs#3090

feat!: remove deprecated APIs#3090
bennypowers merged 1 commit intostaging/pfe5from
feat/remove-deprecated-apis

bennypowers commented Apr 15, 2026

Uh oh!

changeset-bot Bot commented Apr 15, 2026

Uh oh!

github-actions Bot commented Apr 15, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 15, 2026

Uh oh!

github-actions Bot commented Apr 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

bennypowers commented Apr 15, 2026

Summary

Test plan

Uh oh!

changeset-bot Bot commented Apr 15, 2026

🦋 Changeset detected

Uh oh!

github-actions Bot commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Commitlint tests passed!

Uh oh!

github-actions Bot commented Apr 15, 2026

✅ Deploy Preview for patternfly-elements ready!

Uh oh!

github-actions Bot commented Apr 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Apr 15, 2026 •

edited

Loading