i_1244 Get correct name and formal name for contest#1246
Open
johnbrvc wants to merge 3 commits into
Open
Conversation
The CLICS formal_name was never used - this should be the contest title, if present. If not present, then it should be set to the contest (short) name. Add formal_name to the sample clics_sumithello contest CI: Fix ProfilesPane double-click to show more info about the active contest.
Apparently Eclipse adds extra backslashes when you paste an escaped string. *sigh*. I know what I'm doing Eclipse, I don't need your help for this.
johnbrvc
requested review from
JoeTerlizzi,
SamanwaySadhu,
clevengr and
kkarakas
If there is no "id" property, we have to load legacy (pre-clics) contests, which use the short-name property as name, and name as formal_name.
CLICSContestsTest used the wrong name for the contest title, now that we fixed it.
Fix incorrect compare with "ICPC_WF_2011" which should be "ICPC WF 2011".
Update property names in testContestsElement/config/contest.yaml to be clics compliant. Not sure what was there before but it certainly was NOT clics compliant. ("id" is required by ALL CLICS specificaions), and short-name is not part of any CLICS specification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what the PR does
The CLICS formal_name
contest.yamlproperty was never used - this should be the contest title (in PC2 terms), if present. If not present, then it should be set to the contest (short) name. Add formal_name to the sampleclics_sumithellocontestCI: Fix ProfilesPane double-click to show more info about the active contest, eg. Profile ID, Contest ID, ContestInformation Name and ContestInformation Title (formal name).
Issue which the PR addresses
Fixes #1244
Environment in which the PR was developed (OS,IDE, Java version, etc.)
java version "1.8.0_321"
Java(TM) SE Runtime Environment (build 1.8.0_321-b07)
Java HotSpot(TM) 64-Bit Server VM (build 25.321-b07, mixed mode)
Precise steps for testing the PR (i.e., how to demonstrate that it works correctly)
pc2server --server --login s --contestpassword contest --load samps\contests\clics_sumithello)pc2ef --login ef1)curl -k https://administrator1:administrator1@localhost:50443/contests/SumH{"id":"SumH","name":"Sumit Hello Sample","formal_name":"The Sumit Hello Sample Contest", "start_time":null,"countdown_pause_time":null,"duration":"5:00:00","scoreboard_freeze_duration":"1:00:00", "scoreboard_thaw_time":null,"scoreboard_type":"pass-fail","penalty_time":20}curl -k https://administrator1:administrator1@localhost:50443/contests/SumH/event-feed{"type":"contest","token":"pc2-1","id": null,"data": {"id":"SumH","name":"Sumit Hello Sample", " formal_name":"The Sumit Hello Sample Contest","start_time":null,"countdown_pause_time":null, " duration":"5:00:00","scoreboard_freeze_duration":"1:00:00","scoreboard_thaw_time":null, " scoreboard_type":"pass-fail","penalty_time":20}}