Minor fixes to the dns server for the pool.#563
Open
davidv1992 wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #563 +/- ##
==========================================
- Coverage 70.15% 69.97% -0.18%
==========================================
Files 69 69
Lines 14856 14912 +56
==========================================
+ Hits 10422 10435 +13
- Misses 4434 4477 +43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
davidv1992
force-pushed
the
fixup-dns-server
branch
from
664ab54 to
a341108
Compare
Ensures the global region is always present, that we only include suitable servers, and that we properly present the servers at the _ntske._tcp subdomain.
davidv1992
force-pushed
the
fixup-dns-server
branch
from
a341108 to
46fa333
Compare
squell
reviewed
May 21, 2026
| let mut regions = HashMap::new(); | ||
|
|
||
| for server in &servers { | ||
| if !(server.ipv4_capable.unwrap_or(true) || server.ipv6_capable.unwrap_or(true)) |
Member
There was a problem hiding this comment.
I'd prefer this to read
Suggested change
| if !(server.ipv4_capable.unwrap_or(true) || server.ipv6_capable.unwrap_or(true)) | |
| if !server.ipv4_capable.unwrap_or(true) && !server.ipv6_capable.unwrap_or(true) |
The DeMorganization that needs to happen to understand the original formula in combination with 'unwrap_or(true)' gives a kind of double-negation shortcircuit in my brain.
Or perhaps even more clear, this could read:
if server.ipv4_capable == Some(false) && server.ipv6_capable == Some(false)
Member
|
Note: also needs a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures the global region is always present, that we only include suitable servers, and that we properly present the servers at the _ntske._tcp subdomain.