Implement support for multiple local addresses on the same socket#170
Open
davidv1992 wants to merge 11 commits intomainfrom
Open
Implement support for multiple local addresses on the same socket#170davidv1992 wants to merge 11 commits intomainfrom
davidv1992 wants to merge 11 commits intomainfrom
Conversation
It will always error otherwise, so it doesn't really make sense to provide it for general sockets.
These shouldn't be created by downstream users anyway, and this way we can add additional fields to them in the future.
This allows us to more efficiently provide a fallback for destination addresses later. It also allows us to make the local_addr function infallible.
This makes this calculation easier to change once we add additional control messages, for example for destination addresses.
This allows the application to use the proper source address when sending a reply, once properly implemented for all platforms.
davidv1992
force-pushed
the
local-addr
branch
5 times, most recently
from
a865afb to
2a44b83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for getting the local destination address on a recv, and setting the local origin address on send. This is needed to properly support multi-homed servers in ntpd-rs.