Skip to content

K8SPG-1080 v3 module#1686

Draft
oksana-grishchenko wants to merge 37 commits into
mainfrom
K8SPG-1080-v3-module
Draft

K8SPG-1080 v3 module#1686
oksana-grishchenko wants to merge 37 commits into
mainfrom
K8SPG-1080-v3-module

Conversation

@oksana-grishchenko

@oksana-grishchenko oksana-grishchenko commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

v3 module

Problem:
K8SPG-1080
PG 3.0.0 is released while go module still references v2 which makes it harder to use it.

Solution:
Implement v3 module

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PG version?
  • Does the change support oldest and newest supported Kubernetes version?

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Comment thread cmd/postgres-operator/main.go
Comment thread internal/bridge/crunchybridgecluster/postgres_test.go
Comment thread internal/controller/postgrescluster/helpers_test.go
Comment thread internal/controller/postgrescluster/pgmonitor_test.go
Comment thread internal/controller/postgrescluster/snapshots.go
Comment thread internal/controller/standalone_pgadmin/configmap.go
Comment thread internal/controller/standalone_pgadmin/statefulset.go
Comment thread internal/controller/standalone_pgadmin/volume.go
Comment thread percona/controller/pgcluster/owner_ref_migration.go
Comment thread percona/controller/pgrestore/snapshot/reconcile_test.go
Comment thread internal/controller/standalone_pgadmin/configmap.go
Comment thread internal/controller/standalone_pgadmin/service.go
Comment thread hack/create-todo-patch.sh
@@ -9,10 +9,10 @@ import (

var (
// GroupVersion is group version used to register these objects
GroupVersion = schema.GroupVersion{Group: "pgv2.percona.com", Version: "v2"}
GroupVersion = schema.GroupVersion{Group: "pgv3.percona.com", Version: "v2"}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't want to change this and don't need to to use v3 in go

Comment thread hack/create-todo-patch.sh
Comment thread hack/create-todo-patch.sh

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 267 out of 267 changed files in this pull request and generated 6 comments.

Comments suppressed due to low confidence (1)

internal/controller/postgrescluster/pki.go:77

  • reconcileRootCertificate no longer checks for the legacy root CA secret name (naming.RootCertSecret), even though that constant is still documented as required for upgrades (K8SPG-555). This can cause an operator upgrade to silently mint a new CA instead of reusing/migrating the existing one, breaking client connections.

Comment thread pkg/apis/upstream.pgv2.percona.com/v1beta1/shared_types.go
Comment thread pkg/apis/upstream.pgv2.percona.com/v1beta1/shared_types.go
Comment thread pkg/apis/upstream.pgv2.percona.com/v1beta1/zz_generated.deepcopy.go
Comment thread pkg/apis/upstream.pgv2.percona.com/v1beta1/zz_generated.deepcopy.go
Comment thread build/postgres-operator/Dockerfile
Comment thread percona/naming/prefix.go
@JNKPercona

Copy link
Copy Markdown
Collaborator
Test Name Result Time
backup-enable-disable passed 00:16:56
builtin-extensions passed 00:06:36
cert-manager-tls passed 00:10:56
custom-envs passed 00:19:24
custom-tls passed 00:06:10
database-init-sql passed 00:02:41
demand-backup passed 00:24:14
demand-backup-offline-snapshot passed 00:20:30
dynamic-configuration passed 00:04:01
finalizers passed 00:04:32
init-deploy passed 00:03:34
huge-pages passed 00:03:13
major-upgrade-14-to-15 passed 00:11:34
major-upgrade-15-to-16 passed 00:11:09
major-upgrade-16-to-17 passed 00:10:24
major-upgrade-17-to-18 passed 00:10:55
ldap passed 00:03:49
ldap-tls passed 00:05:40
monitoring passed 00:08:08
monitoring-pmm3 passed 00:09:55
one-pod passed 00:06:00
operator-self-healing passed 00:11:03
pgbouncer-mtls passed 00:03:52
pitr passed 00:12:33
scaling passed 00:05:21
scheduled-backup passed 00:32:12
self-healing passed 00:09:23
sidecars passed 00:02:57
standby-pgbackrest passed 00:21:31
standby-streaming passed 00:13:57
start-from-backup passed 00:11:17
tablespaces passed 00:07:45
telemetry-transfer passed 00:04:56
upgrade-consistency passed 00:06:39
upgrade-minor passed 00:07:42
users passed 00:05:30
migration-from-crunchy-standby passed 00:18:39
migration-from-crunchy-pv passed 00:08:46
migration-from-crunchy-backup-restore passed 00:19:35
Summary Value
Tests Run 39/39
Job Duration 02:17:34
Total Test Time 06:44:21

commit: 2d44e62
image: perconalab/percona-postgresql-operator:PR-1686-2d44e6258

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants