Skip to content

Fix ERD delete crash on a stale foreign-key column (#8318) #10042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dpage wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −1
Open

Fix ERD delete crash on a stale foreign-key column (#8318) #10042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/en_US/release_notes_9_16.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,5 @@ Housekeeping

Bug fixes
*********

| `Issue #8318 <https://github.com/pgadmin-org/pgadmin4/issues/8318>`_ - Fixed an error ("i.default.find(...) is undefined") that prevented deleting a table or relationship link in the ERD tool when a foreign key referenced a column that had been renamed.
2 changes: 1 addition & 1 deletion web/pgadmin/tools/erd/static/js/erd_tool/ERDCore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,7 +526,7 @@ export default class ERDCore {
let newForeingKeys = [];
tableData.foreign_key?.forEach((theFkRow)=>{
let theFk = theFkRow.columns[0];
Comment on lines 526 to 528
let attnum = _.find(tableNode.getColumns(), (col)=>col.name==theFk.local_column).attnum;
let attnum = _.find(tableNode.getColumns(), (col)=>col.name==theFk.local_column)?.attnum;
/* Skip all those whose attnum and table matches to the link */
if(linkData.local_column_attnum != attnum || linkData.referenced_table_uid != theFk.references) {
newForeingKeys.push(theFkRow);
Expand Down
Loading