Fix issue with Username being required for Shared server import config

[KijongHan]

Resolves #9226

What does this PR do?

This PR resolves Username attribute not found for server 'shared_server' errors where server json import validation logic had a hard constraint on Username being required even when Shared was set to true. This PR introduces more coherent constraint validation logic for shared servers so that you are required to either provide SharedUsername or Username (for backwards compatibility). Furthermore, the underlying data model 'Username' property is set to 'SharedUsername' (for shared servers only) to align with UI behaviour for setting this fallback.

The UX also feels better as when after registering shared servers with only the SharedUsername set, when trying to connect to the server for the first time it prompts for the password (instead of showing an infinite loading spinner because the underlying Username is not set)

Summary of changes

add separate Username constraint validation logic for shared servers when importing servers.json
add fallback to set Username to SharedUsername for shared servers so that the UX flow matches the manual UI creation flow for registering new shared servers

Summary by CodeRabbit

• Bug Fixes
  • Improved import and validation of shared database servers: shared servers are now skipped for non-admin users, username requirements are enforced conditionally (allowing a shared-specific username when appropriate), and the effective credential used for imported servers is computed reliably. This yields more accurate configuration, fewer import errors, and improved security when handling shared server entries.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a8598914-2de6-454b-9393-fa261071199b

📥 Commits

Reviewing files that changed from the base of the PR and between 034c8f2 and 62437ab.

📒 Files selected for processing (1)

• web/pgadmin/utils/__init__.py

🚧 Files skipped from review as they are similar to previous changes (1)

• web/pgadmin/utils/init.py

---

Walkthrough

Validation and loader functions in web/pgadmin/utils/init.py now derive an is_shared flag from input and compute an effective username (using SharedUsername when appropriate). Validation enforces username requirements conditionally for shared vs non-shared servers; the loader applies computed shared and username values to the server objects.

Changes

Shared Server Configuration and Validation

Layer / File(s)	Summary
Shared server validation logic web/pgadmin/utils/__init__.py	validate_json_data derives is_shared from input and uses it to gate non-admin shared-server imports. When Service is absent it validates Port first, then enforces username requirements: non-shared servers must have Username; shared servers must have Username or SharedUsername.
Load and apply computed server configuration web/pgadmin/utils/__init__.py	load_database_servers computes is_shared and derives an effective username (falling back to SharedUsername when Username is missing for shared servers), then assigns new_server.username, new_server.shared, and new_server.shared_username from those computed values.

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: fixing the issue where Username is required for shared server imports.
Linked Issues check	✅ Passed	The PR addresses #9226 by allowing SharedUsername or Username for shared servers and setting server.username to SharedUsername when Username is missing, with fallback using 'is None' check per reviewer feedback.
Out of Scope Changes check	✅ Passed	All changes in the PR are directly related to fixing the shared server import issue described in #9226; no out-of-scope modifications detected.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Stopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a @coderabbit review after the pipeline has finished.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR updates pgAdmin’s servers.json import path to correctly handle shared servers by loosening validation so shared server definitions can provide SharedUsername instead of always requiring Username, and by applying a fallback so imported shared servers have an effective username consistent with the UI flow.

Changes:

• Adjusted servers.json validation to accept either Username or SharedUsername for shared servers.
• Updated server import to populate Server.username from SharedUsername when Username is not provided for shared servers.
• Minor refactor to reuse computed is_shared during validation/import.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

[asheshv]

Thanks for the careful analysis @KijongHan, and for not just rolling over to Copilot — your read on Username vs SharedUsername precedence matches the UI flow and is the right call. Username is the per-user override, SharedUsername is the group default, and Username winning when both are present is the correct semantics.

One ask before this lands: please change the fallback at line 739 from

if is_shared and not username:
    username = shared_username

to

if is_shared and username is None:
    username = shared_username

Reason: @hiteshjambhale's reproducer (Username: "" with SharedUsername absent) gets username = None after the fallback, and Server.username is nullable=False in the model. The current non-shared branch has the same latent issue with empty strings, but it's pre-existing — this PR widens the path on the shared branch, which the is None check closes without changing any other behaviour.

The broader question — should {"Username": ""} be valid input at all, given PostgreSQL won't authenticate with an empty username? — is worth a separate issue (and I'd argue the answer is no, validation should reject it for both shared and non-shared, parallel to the Service escape hatch). Happy to file that follow-up so this PR can stay scoped.

On the shared_username "purity" point: I agree with you — shared_username is the group default, it shouldn't silently inherit from a legacy Username field. Your handling there is correct.

[KijongHan]

thanks so much for your reviews @asheshv @hiteshjambhale and appreciate the followup to some of the questions I've posed. Have addressed your suggested changes.

[KijongHan]

hi @hiteshjambhale @asheshv Checking to see if you had a chance to rereview my changes that addresses your PR feedback/concerns? Keen to get these changes in!