fix: windows build#1074
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
imor
commented
Jun 13, 2026
| #[cfg(target_os = "linux")] | ||
| if let Some(retries) = config.retries() { | ||
| params = params.with_retries(retries); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
with_retries is not available on Windows.
| // Test cases in this file are run only on unix because of missing sighup | ||
| // support on Windows. | ||
| #![cfg(unix)] | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Tests in this file rely on using the sighup signal on unix OSes to reload the config. Since sighup is not available on windows, this test is skipped on windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest code did not build on windows.