Docs refresh sweep: validation packs, dynamic sources, viewer feature guide#141
Merged
Conversation
… guide Refreshes the documentation to reflect work merged from #126 through #140 and reshapes the viewer README around user-visible features. Top-level README (src tree): - Add 'Validation pack' column to the supported-standards table — all fifteen products now ship a normative rule pack. - Refresh package descriptions (Pipelines, MCP, S-57 delegation). - Drop stale .NET 8 badge; condense gallery into a single table. Viewer README: - Major reshape into a user-facing feature guide. Lead with supported products, then capabilities organised around how the user reaches them (loading data, map view, layer stack with S-98 hand-off, picking, display category & palette, time-varying data, validation, own-ship & dynamic overlays, MCP server, settings persistence). - Drop click-modifier minutiae, internal type names, per-resx-key trivia, and implementation notes from the body; keep a short 'For developers' section pointing to the library READMEs and design notes. Library READMEs: - Core: ICoveragePortrayalCatalogue.ResolveColorScheme is now nullable (#140); validation framework now backs fifteen rule packs with the spec-aligned façade pattern (S-101); GroupPath sidecar convention. - S-102 / S-104: note GroupPath fields used as RelatedFeatureId. - S-101: add Validation section (V-4 façade + 10 rules) and a Bundled-adapter Lua patch note covering the contains / GetFeatureName patches in S101LuaRuleExecutor (#132). - S-111: add Validation section (V-3, 8 rules). - S-57: add Validation section (V-5 pre-translation pack + delegation to S101DatasetRules.Default with S101-as-S57/ rebadge). New EncDotNet.S100.Datasets.Pipelines/README.md: - Per-spec processor table; Validate() contract (lazy + cached, ValidationReport?; null = no pack vs Empty = clean); S-57's pre+post composite report with ConcatReports rebadge; S-98 interoperability authority overview. Docs site: - docs/index.md: replace 3-line stub with project overview, the per-product matrix linking to library READMEs, and a 'Design notes' section enumerating each docs/design/*.md. - docs/toc.yml: group existing pages and add dynamic-feature-source and own-ship-symbology design notes under a 'Design notes' parent. - index.md (DocFX root): expand package list to include every project actually present (Pipelines, S-57, S-122, S-127, S-128, S-131, S-201, MCP, MCP.Tools). No .cs files touched. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Performance Gate✅ PASSED — no regressions. Threshold: 10.0%, MAD multiplier (k): 3.0, retry-zone mult: 1.0× Scenario summary
s101-portray-coldIteration statistics
Spans (sum of all iterations)
Metrics
Generated by EncDotNet.S100.PerfReport gate command |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refreshes repo documentation to reflect work merged from #126–#140 and reshapes the viewer README around user-visible features. Doc-only — no
.csfiles touched.What's covered
Validation framework (PRs #134, #135, #137, #138, #139)
All fifteen supported products now ship a validation rule pack. Documented in:
src/EncDotNet.S100.Core/README.md— façade pattern (S-101'sS101DatasetView),GroupPathsidecar convention, 15-pack coverage statement.src/EncDotNet.S100.Datasets.Pipelines/README.md(new) — uniformValidate()contract (lazy + cached,ValidationReport?;null= no pack vsEmpty= clean); S-57's pre-translation pass +ConcatReportsS101-as-S57/rebadge.src/EncDotNet.S100.Datasets.S{101,102,104,111,57}/README.md— per-pack rule tables, severities, and entry-point examples.Dynamic feature sources (PRs #130, #131, #136)
IDynamicFeatureRenderer/OwnShipRenderer/DefaultDynamicFeatureRenderer/KindMatchingRenderer/CompositeDynamicFeatureRenderer; verified accurate (no edit).S-111 portrayal fidelity (PR #140)
ICoveragePortrayalCatalogue.ResolveColorSchemeis now nullable.S-101 area-text fix (PR #132)
containsandGetFeatureNamepatches inS101LuaRuleExecutorand the principle thatcontent/S101/pc/stays byte-identical to upstream.Viewer panel polish (PRs #126, #127, #128, #129)
Doc site
docs/index.md: replaces 3-line stub with a project overview, the per-product matrix linking to library READMEs, and a Design notes section enumerating eachdocs/design/*.md.docs/toc.yml: groups design notes under a Design notes parent and addsdynamic-feature-sourceandown-ship-symbologyentries.index.md(DocFX root): expands the package table to include every project actually present (Pipelines, S-57, S-122, S-127, S-128, S-131, S-201, MCP, MCP.Tools).Notes
docs/toc.ymlor link to a doc that isn't onmain. Easy follow-up to adddocs/design/non-gml-validation.mdto the TOC when Add non-GML validation design note #133 lands.IDatasetProcessor.Validate()insrc/EncDotNet.S100.Datasets.Pipelines/IDatasetProcessor.cssays "no rule pack is yet defined for this spec (e.g. coverage products and S-101 / S-201 / S-57 today)". All three now ship packs — the example list should be removed (or the comment should just keep thenullvsEmptydistinction it already covers correctly). Worth a one-line follow-up.Files
Roadmap-review session:
2c830a69-d34c-44be-813b-555cb6644bbe.