Add eex suffix to phx.gen.auth template override test#6680
Conversation
|
I may be misremembering, but I think I deliberately kept it to check the backwards compatibility. If there’s a different test already verifying that, this is fine though. |
Ohh, didn't know it was deliberate. I have seen the backward compatibility check for missing eex extension. https://github.com/phoenixframework/phoenix/pull/6598/changes#diff-3a04e676440d973e029640b657bc41b45f2f2931a9558c5518a601f8b375f097R42 I happened to have a custom template generator and the test was failing because there was an eex file from the custom generator. Since the test didn't use the eex extension, the custom generator overshadowed the non eex test file. I thought it was an oversight because a somewhat similar test extension change was made for phx.gen.live. https://github.com/phoenixframework/phoenix/pull/6598/changes#diff-665fb2702d1d485d1c09ac7ce62f5479550934824a26da3d0954eb3cd98bc119R33 |
|
It would be better to add a dedicated test for it. If you want to do that, feel free to go ahead and add another test block that mentions it‘s testing backwards compat. |
#6598 added eex suffix. This just makes sure phx.gen.auth template override test also uses eex suffix.