Cache sub-encoder isos in ScalarTypeEncoder#54
Closed
veewee wants to merge 1 commit intophp-soap:mainfrom
Closed
Conversation
Builds the int/float/string/bool isos once in iso() instead of creating new encoder instances and calling iso() on every encode.
Member
Author
|
Closing: the 4 sub-encoder isos are only used in the to() direction, while decode (the hot path) doesn't use them at all. This means we eagerly allocate 4 unused isos on every decode call. No measurable benefit, slight waste on decode. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Captures the int/float/string/bool isos once in
iso()instead of creatingnew IntTypeEncoder()etc. and calling->iso($context)on every encode invocation.Impact
<1% (negligible). Each sub-encoder's
iso()is trivially cheap. The value is consistency:iso()should capture its dependencies eagerly, not rebuild them per call.Test plan