Cache type iso in AttributeValueEncoder#55
Merged
veewee merged 1 commit intophp-soap:mainfrom Mar 26, 2026
Merged
Conversation
Captures $this->typeEncoder->iso($context) once in iso() and passes it to the private to() and from() methods. Previously called up to 4 times per encode/decode (fixed value check, encode, decode, default).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Captures
$this->typeEncoder->iso($context)once iniso()and passes the cached iso to the privateto()andfrom()methods. Previously the iso was rebuilt up to 4 times per encode/decode cycle (fixed value check, encode, decode value, decode default/fixed fallback).Impact
<1% (attributes are less common than elements). Same pattern as #52 and #53: capture the iso eagerly, pass it to private methods.
Test plan