Cache ObjectAccess::forContext() using ScopedCache#57
Merged
veewee merged 1 commit intophp-soap:mainfrom Mar 26, 2026
Merged
Conversation
ObjectAccess::forContext() rebuilds the full property mapping for a complex type on every encode/decode: iterates all properties, detects encoders, creates lenses, and builds isos. Now cached per (registry, namespace, typeName, bindingUse) using ScopedCache. Cache key includes bindingUse because the isos capture binding-dependent behavior (xsi:type attributes in encoded mode, XMLWriter bypass in literal mode). ~20-25% improvement on both encode and decode paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ObjectAccess::forContext()rebuilds the full property mapping for a complex type on every encode/decode call: iterates all properties from metadata, detects encoders for each, creates encoder/decoder lenses, and builds isos. This is the most expensive operation on the hot path.Now cached per
(registry, namespace, typeName, bindingUse)usingScopedCache(introduced in #56).Cache key
namespace|typeName: determines which type and properties are resolved from metadatabindingUse: affects the iso closures (xsi:type attributes in encoded mode, XMLWriter bypass in literal)registry: is the WeakMap scope (separate cache per driver instance)Why bindingUse is in the key
The same complex type used with
literalvsencodedbinding produces different isos: encoded mode adds xsi:type attributes viaXsiAttributeBuilder, literal mode may bypass XMLWriter entirely. A test verifies this by comparing the XML output of the same type with both bindings.Impact (local benchmark)
Test plan