Migrate to veewee/xml v4 and PHP 8.4+#58
Merged
veewee merged 1 commit intophp-soap:mainfrom Mar 27, 2026
Merged
Conversation
- Bump minimum PHP to 8.4, drop 8.3 from CI - Upgrade veewee/xml ^3.6 to ^4.10 (spec-compliant DOM API) - Replace DOMDocument/DOMElement/DOMNode/DOMAttr with Dom\ equivalents - Replace deprecated Document::configure(loader(...)) with Document::fromLoader() - Use assert_document() for ownerDocument access (now ?Dom\Document) - Fix getAttribute/getAttributeNS null returns (was empty string) - Remove redundant null coalescing on localName (now non-nullable) - Fix textContent nullability in fault encoders - Update Soap12FaultEncoderTest for changed namespace serialization order - Bump php-soap/* packages to latest versions - Switch to standalone PSL dependencies (^6.1) - Add DOM stubs and phpVersion to psalm.xml
veewee
force-pushed
the
feature/veewee-xml-v4-migration
branch
from
f16cfca to
3d30bd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
veewee/xmlfrom ^3.6 to ^4.10 (PHP 8.4 spec-compliant DOM API)DOMDocument/DOMElement/DOMNode/DOMAttrwithDom\namespace equivalentsDocument::configure(loader(...))withDocument::fromLoader()getAttribute/getAttributeNSreturnnullinstead of'',textContentis?string,localNameis now non-nullablestringassert_document()forownerDocumentaccess (now?Dom\Document)Soap12FaultEncoderTestfor changed namespace declaration serialization orderphp-soap/*packages to latest versionsphp-soap/engine-integration-teststo ^1.12 (fixesnodeValuevstextContentfor new DOM)phpVersion="8.4"topsalm.xmlTest plan
docphpro/php84(PHP 8.4.19, libxml 2.9.14)