Migrate XopIncludeEncoder to STAB optics#14
Merged
Conversation
veewee
force-pushed
the
feature/reflecta-stab-migration
branch
from
ce33e5d to
4d3cb93
Compare
veewee
force-pushed
the
feature/reflecta-stab-migration
branch
from
4d3cb93 to
7318589
Compare
Update XmlEncoder/Iso generics to 4-template STAB form for the new veewee/reflecta interfaces. The iso() return declares the honest asymmetric shape (Element|non-empty-string accepted on the from input fast path). Composer wires the local encoding migration branch and local reflecta feature/stab-optics via path repositories.
veewee
force-pushed
the
feature/reflecta-stab-migration
branch
from
7318589 to
1f7779d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
XopIncludeEncoderto the four-template STAB form (Iso<S, T, A, B>/XmlEncoder<TDataIn, TDataOut, TXmlOut, TXmlIn>) introduced by veewee/reflecta#31 and php-soap/encoding#64.Summary
@implements XmlEncoder<Attachment, non-empty-string>→XmlEncoder<Attachment, Attachment, non-empty-string, Element|non-empty-string>— element-aware encoder declares its honestfrominput shape.iso()return docblock updated to the same 4-slot shape.cid()helper iso stays monomorphic:Iso<Attachment, Attachment, non-empty-string, non-empty-string>.Runtime behavior unchanged.
Requirements
composer.jsonreferences both via dev-branch aliases. Once those land as real releases, drop the aliases and pin to the stable versions.Test plan
vendor/bin/psalm --no-cachegreen (no errors)vendor/bin/phpunit --no-coveragegreen (25 tests, 93 assertions)