Guard against missing twig_callable attribute#531
Merged
bocharsky-bw merged 3 commits intoMay 11, 2026
Merged
Conversation
bocharsky-bw
reviewed
May 8, 2026
Member
bocharsky-bw
left a comment
bocharsky-bw
left a comment
There was a problem hiding this comment.
Thanks! Could you please fix code styles here?
| } | ||
|
|
||
| if (!$transNode instanceof FilterExpression) { | ||
| if (!$transNode instanceof FilterExpression || !$transNode->hasAttribute('twig_callable')) { |
Member
There was a problem hiding this comment.
Just to be clear, do you think it's OK to throw this exception if we have a FilterExpression instance, but it does not have twig_callable attribute on it?
Contributor
Author
There was a problem hiding this comment.
Code style issues fixed. The reported violations were related to missing : void return types in existing code.
Good point regarding the additional guard logic.
The original exception behavior is now preserved for actual invalid desc chains, while custom FilterExpression implementations without the twig_callable attribute are skipped by returning the original node.
bocharsky-bw
approved these changes
May 11, 2026
Member
bocharsky-bw
left a comment
bocharsky-bw
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR added with a minimal compatibility fix for custom FilterExpression nodes that do not expose the "twig_callable" attribute.
The changes only add guard checks before accessing the attribute, without changing the existing behavior for regular Twig filter expressions.