Skip to content

Treat IDREF mismatches as warnings in non-English translations #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jordikroon wants to merge 2 commits into
base: master
Choose a base branch
from
+16 −7
Open

Treat IDREF mismatches as warnings in non-English translations #303

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90ebffd
treat IDREF mismatches as warnings in non-English translations
jordikroon Jun 17, 2026
de701ba
Show all errors
Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions configure.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -985,19 +985,28 @@ function xml_validate_jing()
$cmdJing = "java -jar {$srcdir}/docbook/jing.jar {$schema} {$idempath}";
exec( $cmdJing , $out , $ret );

if ( ! is_array( $out ) )
$out = [];

if ( $ret == 0 )
{
echo "done.\n";
return;
}
else
{
echo "failed.\n";
if ( is_array( $out ) )
foreach ( $out as $line )
echo "$line\n";

echo "failed.\n";
foreach ( $out as $line )
echo "$line\n";

// Allow translations with missing/mismatched IDREFs to continue building.

$countFatal = count( $out );
foreach ( $out as $line )
if ( preg_match( '/IDREF "[^"]+" without matching ID/', $line ) )
$countFatal--;

if ( $GLOBALS['ac']['LANG'] === 'en' || $countFatal > 0 )
errors_are_bad( 1 );
}
}

function xml_validate_libxml( $dom )
Expand Down