Add missing ext/operator documentation#4669
Conversation
|
I would like to note that since this is a new documentation the workflow run https://github.com/php/doc-en/actions/runs/14958493251/job/42050000015 is going to fail until the related pull request php/doc-base#246 is merged. |
|
Great👍 |
|
Quick heads up... Given that PECL was deprecated (after this PR was opened) I believe the references to PECL in this PR should be removed. |
I am trying to update this to use PIE, but it is still using PECL. I have not yet had the time to do that yet. I will reorganize my todo list and move this up in priority. |
|
Hi @jb-lopez, I have previously stated that I would recommend you to move this extension to PIE. However given the historical record of this extension I am fine if this links to PECL for the moment. As for what blocks this PR, nothing really. And I would like to have this merged before an eventual passing or rejection of RFC to split third-party extensions for the docs. The reason is that if this is merged, we can do a lift and shift rather than that we have to deal with an open PR that needs to target a different repository. We have recently introduced a sniffer tool (Docbook-CS). I would like to request you to rebase this PR with the master. That will give you some violations (like para to simpara). Once those are resolved (shouldn't be too difficult). We will merge the extension. |
jb-lopez
force-pushed
the
master
branch
2 times, most recently
from
ef09d4c to
3a6a39e
Compare
|
@jordikroon Thank you for the reply. I have been able to add PIE support to the extension. I have opened the PR here and have tested that I can install via I will work on updating the installation instructions to be for PIE instead of PECL here shortly. I expected the Integrate test to fail. As I mentioned in the description, the companion PR php/doc-base#246 is mutually dependent with this one. Unless I have done things wrong (perhaps I have, it is my first time writing a new docbook). I think I did the rebase wrong the first time around, but the two PRs are both rebased on master as of now. |
| Another example is creating an enhanced string class that has the multiplication | ||
| operator overloaded to allow repeating the string a certain number of times. | ||
| </simpara> | ||
| <section> |
There was a problem hiding this comment.
Fyi this gave an error upon building.
Validating temp/manual.xml (jing)... failed.
/var/www/doc-base/temp/manual.xml:95854:13: error: element "section" incomplete; expected element "info", "subtitle", "title" or "titleabbrev"
Co-authored-by: Louis-Arnaud <la.catoire@gmail.com>
|
Thank you @jb-lopez. I have taken this on myself and have fixed the style issues. |
|
Hello,
It's good to hear from you.
Thanks for your help.
…On Thu, Jun 25, 2026, 8:17 PM Jordi Kroon ***@***.***> wrote:
*jordikroon* left a comment (php/doc-en#4669)
<#4669 (comment)>
Thank you @jb-lopez <https://github.com/jb-lopez>. I have taken this on
myself and have fixed the style issues.
As this is a big chunk that doc-base depends on, it's best to open a new
PR for the PIE changes specifically.
—
Reply to this email directly, view it on GitHub
<#4669?email_source=notifications&email_token=B3HPYB5M3FAFMN4D3S4KIXD5BVNCVA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBQGIZDSNZWGQ4KM4TFMFZW63VGNVQW45LBNSSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-4802297648>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/B3HPYB53GSBECYAGZMMFPCT5BVNCVAVCNFSNUABFKJSXA33TNF2G64TZHMYTSMBYG4ZTSOJXHNEXG43VMU5TGMBVGUYTGNZYGYZ2C5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/B3HPYB5CLCRV4YMM7WK25JD5BVNCVA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBQGIZDSNZWGQ4KM4TFMFZW63VGNVQW45LBNSSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/B3HPYB4TCJQZ7H2JWWKKLUD5BVNCVA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBQGIZDSNZWGQ4KM4TFMFZW63VGNVQW45LBNSSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
5 participants
This pull request is to add the missing documentation for the PECL operator extension. I have taken over as the lead maintainer for that extension, but this is my first contribution to the PHP documentation so any feedback is welcome. There is a companion pull request to
doc-basethat goes with one and is required by this one. php/doc-base#246There appears to never have been any documentation for the PECL operator extension. For this pull request I've added the test class that ext/operator uses all of its overloading capabilities as a complete code sample.